Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor test.js to use arrow functions #30068

Closed
mpark86 opened this issue Oct 22, 2019 · 5 comments
Closed

Refactor test.js to use arrow functions #30068

mpark86 opened this issue Oct 22, 2019 · 5 comments

Comments

@mpark86
Copy link
Contributor

mpark86 commented Oct 22, 2019 •
edited

According to the provided test guidelines, it is preferred to use arrow functions for call backs. test/addons/make-callback-recurse/test.js contains many regular functions with common.mustCall(), so it needs to be refactored.
@mpark86
Copy link
Contributor Author

mpark86 commented Oct 22, 2019

I would like to start working on this.

mpark86 added a commit to mpark86/node that referenced this issue Oct 22, 2019
@mpark86
Fix nodejs#30068: refactored to use arrow functions
fd0b250
@Trott
Copy link
Member

Trott commented Oct 22, 2019

There are 83 files in subdirectories of the test directory named test.js.

@Trott
Copy link
Member

Trott commented Oct 22, 2019

Ah, I see from the PR you are referring to test/addons/make-callback-recurse/test.js.

@gireeshpunathil gireeshpunathil mentioned this issue Oct 23, 2019
Closed
@mpark86
Copy link
Contributor Author

mpark86 commented Oct 24, 2019

Thanks for pointing that out. I just fixed the issue description to include the full path as well.

@Trott
Copy link
Member

Trott commented Oct 25, 2019

Closed by 175c318

@Trott Trott closed this as completed Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Trott @mpark86