Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test.js to use arrow functions #30068

Closed
mpark86 opened this issue Oct 22, 2019 · 5 comments
Closed

Refactor test.js to use arrow functions #30068

mpark86 opened this issue Oct 22, 2019 · 5 comments

Comments

@mpark86
Copy link
Contributor

@mpark86 mpark86 commented Oct 22, 2019

According to the provided test guidelines, it is preferred to use arrow functions for call backs. test/addons/make-callback-recurse/test.js contains many regular functions with common.mustCall(), so it needs to be refactored.

@mpark86

This comment has been minimized.

Copy link
Contributor Author

@mpark86 mpark86 commented Oct 22, 2019

I would like to start working on this.

mpark86 added a commit to mpark86/node that referenced this issue Oct 22, 2019
@Trott

This comment has been minimized.

Copy link
Member

@Trott Trott commented Oct 22, 2019

There are 83 files in subdirectories of the test directory named test.js.

@Trott

This comment has been minimized.

Copy link
Member

@Trott Trott commented Oct 22, 2019

Ah, I see from the PR you are referring to test/addons/make-callback-recurse/test.js.

@mpark86

This comment has been minimized.

Copy link
Contributor Author

@mpark86 mpark86 commented Oct 24, 2019

Thanks for pointing that out. I just fixed the issue description to include the full path as well.

@Trott

This comment has been minimized.

Copy link
Member

@Trott Trott commented Oct 25, 2019

Closed by 175c318

@Trott Trott closed this Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.