Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent test failure on v10.x #30828

Closed
gabrielschulhof opened this issue Dec 7, 2019 · 3 comments
Closed

Consistent test failure on v10.x #30828

gabrielschulhof opened this issue Dec 7, 2019 · 3 comments

Comments

@gabrielschulhof
Copy link
Contributor

https://ci.nodejs.org/job/node-test-binary-arm/7976/RUN_SUBSET=3,label=pi1-docker/console

18:45:35 not ok 388 sequential/test-https-server-keep-alive-timeout
18:45:35   ---
18:45:35   duration_ms: 4.483
18:45:35   severity: fail
18:45:35   exitcode: 1
18:45:35   stack: |-
18:45:35     events.js:174
18:45:35           throw er; // Unhandled 'error' event
18:45:35           ^
18:45:35     
18:45:35     Error: write EPIPE
18:45:35         at WriteWrap.afterWrite [as oncomplete] (net.js:789:14)
18:45:35     Emitted 'error' event at:
18:45:35         at errorOrDestroy (internal/streams/destroy.js:107:12)
18:45:35         at onwriteError (_stream_writable.js:436:5)
18:45:35         at onwrite (_stream_writable.js:461:5)
18:45:35         at _destroy (internal/streams/destroy.js:49:7)
18:45:35         at TLSSocket.Socket._destroy (net.js:614:3)
18:45:35         at TLSSocket.destroy (internal/streams/destroy.js:37:8)
18:45:35         at WriteWrap.afterWrite [as oncomplete] (net.js:791:10)
@Trott
Copy link
Member

Trott commented Dec 7, 2019

@nodejs/platform-arm

@gabrielschulhof
Copy link
Contributor Author

Others where it failed:

https://ci.nodejs.org/job/node-test-binary-arm/7975/RUN_SUBSET=3,label=pi1-docker/console
https://ci.nodejs.org/job/node-test-binary-arm/7972/RUN_SUBSET=3,label=pi1-docker/console

bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Dec 7, 2019
@bnoordhuis
test: scale keepalive timeouts for slow machines
94ae663 
The test was using fixed timeouts and that seems to be causing sporadic
test failures on pi1-docker host (which is a very slow machine.)

Fixes: nodejs#30828
@bnoordhuis bnoordhuis mentioned this issue Dec 7, 2019
Closed
@bnoordhuis
Copy link
Member

#30834 should hopefully fix that.

@Trott Trott closed this as completed in ba61253 Dec 9, 2019
targos pushed a commit that referenced this issue Dec 9, 2019
@bnoordhuis @targos
test: scale keepalive timeouts for slow machines
97e0efe 
The test was using fixed timeouts and that seems to be causing sporadic
test failures on pi1-docker host (which is a very slow machine.)

Fixes: #30828

PR-URL: #30834
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this issue Jan 14, 2020
@bnoordhuis @targos
test: scale keepalive timeouts for slow machines
e1eb6a6 
The test was using fixed timeouts and that seems to be causing sporadic
test failures on pi1-docker host (which is a very slow machine.)

Fixes: #30828

PR-URL: #30834
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs pushed a commit that referenced this issue Feb 6, 2020
@bnoordhuis @BethGriggs
test: scale keepalive timeouts for slow machines
55a1a90 
The test was using fixed timeouts and that seems to be causing sporadic
test failures on pi1-docker host (which is a very slow machine.)

Fixes: #30828

PR-URL: #30834
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs pushed a commit that referenced this issue Feb 27, 2020
@bnoordhuis @BethGriggs
test: scale keepalive timeouts for slow machines
5484e06 
The test was using fixed timeouts and that seems to be causing sporadic
test failures on pi1-docker host (which is a very slow machine.)

Fixes: #30828

PR-URL: #30834
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: scale keepalive timeouts for slow machines bnoordhuis/io.js
3 participants
@bnoordhuis @Trott @gabrielschulhof