Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate unreliability in test-dns-any #31721

Closed
Trott opened this issue Feb 10, 2020 · 3 comments · Fixed by #32017
Closed

investigate unreliability in test-dns-any #31721

Trott opened this issue Feb 10, 2020 · 3 comments · Fixed by #32017
Labels
dns Issues and PRs related to the dns subsystem.

Comments

@Trott
Copy link
Member

Trott commented Feb 10, 2020

  • Version: v14.0.0-pre (master branch)
  • Platform: n/a
  • Subsystem: dns

What steps will reproduce the bug?

Run test/internet/test-dns-any.js over and over.

How often does it reproduce? Is there a required condition?

About 50% of the time, but 100% of the time if you run it over and over.

What is the expected behavior?

The test will consistently pass, or consistently fail.

What do you see instead?

It passes sometimes, fails other times.

Additional information

The problem seems to be that Google's DNS servers sometimes return a whole bunch of records with an ANY query on google.com and other times only return A and AAAA. But the test expects all the records. You can verify the aforementioned Google DNS behavior (which may very well be correct for all I know) by running nslookup -type=ANY google.com 8.8.8.8 on the command line (on UNIX) over and over. Sometimes, you get a lot of records, and other times only A and AAAA.

@Trott Trott added the dns Issues and PRs related to the dns subsystem. label Feb 10, 2020
@Trott
Copy link
Member Author

Trott commented Feb 10, 2020

@nodejs/dns

@Trott
Copy link
Member Author

Trott commented Feb 29, 2020

I am now unable to reproduce this locally but it is happening in CI (e.g., https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12504/console).

@Trott
Copy link
Member Author

Trott commented Feb 29, 2020

I am, however, still able to reproduce this from the command line on the CI host using nslookup so this is (again) confirmed to not be a Node.js problem. I'm thinking of seeing what happens if we simply remove the google.com test from the file, as there are other tests for ANY queries in the file.

@Trott Trott closed this as completed in fb74e98 Mar 2, 2020
codebytere pushed a commit that referenced this issue Mar 3, 2020
Remove google.com from domains tested with ANY queries.

Fixes: #31721

PR-URL: #32017
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit that referenced this issue Mar 15, 2020
Remove google.com from domains tested with ANY queries.

Fixes: #31721

PR-URL: #32017
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit that referenced this issue Mar 17, 2020
Remove google.com from domains tested with ANY queries.

Fixes: #31721

PR-URL: #32017
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit that referenced this issue Mar 30, 2020
Remove google.com from domains tested with ANY queries.

Fixes: #31721

PR-URL: #32017
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dns Issues and PRs related to the dns subsystem.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant