-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: recent large performance regressions #31739
Labels
crypto
Issues and PRs related to the crypto subsystem.
performance
Issues and PRs related to the performance of Node.js.
Comments
mscdex
added
crypto
Issues and PRs related to the crypto subsystem.
performance
Issues and PRs related to the performance of Node.js.
labels
Feb 11, 2020
ronag
added a commit
to nxtedition/node
that referenced
this issue
Feb 11, 2020
nodejs@e559842 made writable/readable computed with a legacy mode if the properties are written to. LazyTransform still unecessarily wrote to these properties causing a performance regression. Fixes: nodejs#31739
codebytere
pushed a commit
that referenced
this issue
Feb 17, 2020
e559842 made writable/readable computed with a legacy mode if the properties are written to. LazyTransform still unecessarily wrote to these properties causing a performance regression. Fixes: #31739 PR-URL: #31742 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere
pushed a commit
that referenced
this issue
Mar 15, 2020
e559842 made writable/readable computed with a legacy mode if the properties are written to. LazyTransform still unecessarily wrote to these properties causing a performance regression. Fixes: #31739 PR-URL: #31742 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere
pushed a commit
that referenced
this issue
Mar 17, 2020
e559842 made writable/readable computed with a legacy mode if the properties are written to. LazyTransform still unecessarily wrote to these properties causing a performance regression. Fixes: #31739 PR-URL: #31742 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere
pushed a commit
that referenced
this issue
Mar 30, 2020
e559842 made writable/readable computed with a legacy mode if the properties are written to. LazyTransform still unecessarily wrote to these properties causing a performance regression. Fixes: #31739 PR-URL: #31742 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
crypto
Issues and PRs related to the crypto subsystem.
performance
Issues and PRs related to the performance of Node.js.
While working on a system that automatically and regularly runs benchmarks on master and compares the results between builds, I found some large
crypto
performance regressions between f368210 and 93c4c1a. Here are thecrypto
benchmarks that showed a greater than 10% regression (numeric values below are the % change with "***" confidence):The culprits seem to be at least e559842 and possibly also d016b9d.
/cc @ronag
The text was updated successfully, but these errors were encountered: