New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vm: Function declarations should use [[Define]] instead of [[Set]] on the global object #31808
Comments
7 tasks
Well, |
devsnek
added
v8 engine
Issues and PRs related to the V8 dependency.
vm
Issues and PRs related to the vm subsystem.
labels
Feb 15, 2020
This is fixed by 30709 |
#30709 should include tests for this. |
devsnek
added a commit
to devsnek/node
that referenced
this issue
Feb 17, 2020
Fixes nodejs#855 Fixes nodejs#31658 Fixes nodejs#31808
ExE-Boss
added a commit
to ExE-Boss/node
that referenced
this issue
Jun 23, 2020
3 tasks
@Mesteery Does this test pass?
If not, then this issue should remain open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What steps will reproduce the bug?
How often does it reproduce? Is there a required condition?
Always.
What is the expected behavior?
The functions get defined using
[[DefineOwnProperty]]
as specified in ECMA‑262 § 8.1.1.4.18CreateGlobalFunctionBinding
.Expected log output
What do you see instead?
Additional information
Discovered in: jsdom/jsdom#2835 (comment)
See also
The text was updated successfully, but these errors were encountered: