Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] oaepLabel option missing from crypto.publicEncrypt's "key" value #31810

Closed
BigBrainAFK opened this issue Feb 15, 2020 · 1 comment
Closed

[doc] oaepLabel option missing from crypto.publicEncrypt's "key" value #31810

BigBrainAFK opened this issue Feb 15, 2020 · 1 comment
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.

Comments

@BigBrainAFK
Copy link

While the docs mention the oaepHash value for the object of the key value for the crypto.publicEncrypt function they don't mention the oaepLabel value that can also be specified in said object.
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Feb 17, 2020
@bnoordhuis
doc,crypto: re-document oaepLabel option
3ecb3e8 
Erroneously removed in nodejs#29516.

Fixes: nodejs#31810
Refs: nodejs#29516
@bnoordhuis bnoordhuis mentioned this issue Feb 17, 2020
Closed
@bnoordhuis bnoordhuis added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Feb 17, 2020
@bnoordhuis
Copy link
Member

Looks like it was accidentally removed from the docs in an overhaul. I've opened #31825, thanks for the report.

codebytere pushed a commit that referenced this issue Feb 27, 2020
@bnoordhuis @codebytere
doc,crypto: re-document oaepLabel option
aa16d80 
Erroneously removed in #29516.

Fixes: #31810
Refs: #29516

PR-URL: #31825
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
codebytere pushed a commit that referenced this issue Mar 15, 2020
@bnoordhuis @codebytere
doc,crypto: re-document oaepLabel option
e98626d 
Erroneously removed in #29516.

Fixes: #31810
Refs: #29516

PR-URL: #31825
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
codebytere pushed a commit that referenced this issue Mar 17, 2020
@bnoordhuis @codebytere
doc,crypto: re-document oaepLabel option
5b10791 
Erroneously removed in #29516.

Fixes: #31810
Refs: #29516

PR-URL: #31825
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
codebytere pushed a commit that referenced this issue Mar 30, 2020
@bnoordhuis @codebytere
doc,crypto: re-document oaepLabel option
fd5aa41 
Erroneously removed in #29516.

Fixes: #31810
Refs: #29516

PR-URL: #31825
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc,crypto: re-document oaepLabel option bnoordhuis/io.js
2 participants
@bnoordhuis @BigBrainAFK