Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky test/parallel/test-trace-atomics-wait.js when run in parallel #33427

Closed
targos opened this issue May 16, 2020 · 1 comment
Closed

flaky test/parallel/test-trace-atomics-wait.js when run in parallel #33427

targos opened this issue May 16, 2020 · 1 comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.

Comments

@targos
Copy link
Member

targos commented May 16, 2020

I discovered it with make test -j12
On my local machine:

$ tools/test.py -j10 --repeat 1000 parallel/test-trace-atomics-wait
[00:18|% 100|+ 910|-  90]: Done

Is it expected? Should we move it to sequential?
@addaleax
Copy link
Member

Thanks, I’ll take alook.

Should we move it to sequential?

We should definitely not move a test to sequential just because it’s flaky. I think it’s okay when we really can’t come up with a better solution. (This test is not resource-intensive or conflicts with other tests running in parallel, so it does belong in parallel/.)

@addaleax addaleax added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label May 16, 2020
addaleax added a commit to addaleax/node that referenced this issue May 16, 2020
@addaleax
test: fix flaky test-trace-atomics-wait
4a12dc3 
This adds a possible ordering of the trace events that was missing
from the list previously.

Fixes: nodejs#33427
@addaleax addaleax mentioned this issue May 16, 2020
Closed
3 tasks
codebytere pushed a commit that referenced this issue Jun 18, 2020
@addaleax @codebytere
test: fix flaky test-trace-atomics-wait
be135bf 
This adds a possible ordering of the trace events that was missing
from the list previously.

Fixes: #33427

PR-URL: #33428
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this issue Jun 18, 2020
@addaleax @codebytere
test: fix flaky test-trace-atomics-wait
47396a4 
This adds a possible ordering of the trace events that was missing
from the list previously.

Fixes: #33427

PR-URL: #33428
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this issue Jun 30, 2020
@addaleax @codebytere
test: fix flaky test-trace-atomics-wait
5fd5003 
This adds a possible ordering of the trace events that was missing
from the list previously.

Fixes: #33427

PR-URL: #33428
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flaky test-trace-atomics-wait addaleax/node
2 participants
@addaleax @targos