Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove GitHub Actions for tarballs? #34123

Closed
Trott opened this issue Jun 29, 2020 · 9 comments
Closed

build: remove GitHub Actions for tarballs? #34123

Trott opened this issue Jun 29, 2020 · 9 comments

Comments

@Trott
Copy link
Member

Trott commented Jun 29, 2020

I could be wrong but it seems to me:

  • The tarball jobs take a long time to run.
  • They fail on at least one of Windows or macOS on almost every run on PRs against master.
  • The output is annoying-at-best to work with efficiently.
  • It seems that no one is looking in to why they're failing.
  • It seems that code is landing anyway, despite the failures.

The intention was good, but the end result is not that people are making sure the tarballs build. It's that we're ignoring test failures.

Correction welcome! If these are resulting in activity I'm not seeing, then great! But if not...

Let's disable/remove them?

@Trott
Copy link
Member Author

Trott commented Jun 29, 2020

To be clear: I'd rather keep the action and get building fixed/reliable. But if we're not going to do that, I'm not excited about having basically permanently failing actions.

@richardlau
Copy link
Member

If they're generally passing on Linux perhaps we could start by removing the macOS/Windows tests rather than remove the whole thing?

* The output is annoying-at-best to work with efficiently.

* It seems that no one is looking in to why they're failing.

* It seems that code is landing anyway, despite the failures.

I feel these three points are general to our GitHub Actions workflows in general and not specific to the tarball workflow.

@mmarchini
Copy link
Contributor

Related #33947. I'm fine removing or keeping just Linux.

@richardlau
Copy link
Member

* They fail on at least one of Windows or macOS on almost every run on PRs against master.

I've sampled a few of the Windows failures and they're all failing parallel/test-vm-timeout-escape-promise-2. I've raised #34163.

@mmarchini
Copy link
Contributor

mmarchini commented Jul 1, 2020

I'm still not sure just fixing the test failures will do any good, there are many runs of this action that are hanging/failing with no output (example: https://github.com/nodejs/node/runs/784411094?check_suite_focus=true).

@richardlau
Copy link
Member

This seems as good a place to note this -- until we come up with a better way of representing test results in the actions interface you may find it easier to search through the raw log:
image

@MylesBorins
Copy link
Contributor

I'd like to prod this again... I really think we should consider removing this action and perhaps re-implementing something in our primary CI

@mmarchini
Copy link
Contributor

I'm still +1 on removing it from Actions

MylesBorins added a commit to MylesBorins/node that referenced this issue Jul 22, 2020
This GitHub action takes quite a bit of time to build and is regularly
flaky. Removing the OSX and Windows target from this action to avoid
having red actions CI runs.

Refs: nodejs#34123
MylesBorins added a commit that referenced this issue Jul 23, 2020
This GitHub action takes quite a bit of time to build and is regularly
flaky. Removing the OSX and Windows target from this action to avoid
having red actions CI runs.

Refs: #34123

PR-URL: #34440
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@MylesBorins
Copy link
Contributor

Going to go ahead and close this as we remove windows+ osx from the action, which were AFAIK the platforms that were failing

MylesBorins added a commit that referenced this issue Jul 27, 2020
This GitHub action takes quite a bit of time to build and is regularly
flaky. Removing the OSX and Windows target from this action to avoid
having red actions CI runs.

Refs: #34123

PR-URL: #34440
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants