Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

querystring.unescape does not correctly unescape percent characters #35012

Closed
watilde opened this issue Sep 1, 2020 · 0 comments · Fixed by #35013
Closed

querystring.unescape does not correctly unescape percent characters #35012

watilde opened this issue Sep 1, 2020 · 0 comments · Fixed by #35013
Labels
querystring Issues and PRs related to the built-in querystring module.

Comments

@watilde
Copy link
Member

watilde commented Sep 1, 2020

  • Version: v12, master
  • Platform: Windows, macOS
  • Subsystem: querystring

What steps will reproduce the bug?

const querystring = require('querystring');
console.log( 'expected: %*', `actual: ${querystring.unescape('%%2f')}`);
// => actual: %%2f
console.log( 'expected: %2*f*', `actual: ${querystring.unescape('%2%2af%2a')}`);
// => actual %2%2af*

What is the expected behavior?

It should unescape %2a to *.

What do you see instead?

Capture
@watilde watilde added the querystring Issues and PRs related to the built-in querystring module. label Sep 1, 2020
@watilde watilde mentioned this issue Sep 1, 2020
Merged
3 tasks
@Trott Trott closed this as completed in 3b92521 Sep 4, 2020
richardlau pushed a commit that referenced this issue Sep 7, 2020
@watilde @richardlau
querystring: manage percent character at unescape
3367613 
Related: #33892
Fixes: #35012

PR-URL: #35013
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau pushed a commit that referenced this issue Sep 7, 2020
@watilde @richardlau
querystring: manage percent character at unescape
1bf5d1a 
Related: #33892
Fixes: #35012

PR-URL: #35013
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax pushed a commit that referenced this issue Sep 22, 2020
@watilde @addaleax
querystring: manage percent character at unescape
bde9fb8 
Related: #33892
Fixes: #35012

PR-URL: #35013
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax pushed a commit that referenced this issue Sep 22, 2020
@watilde @addaleax
querystring: manage percent character at unescape
6ccacdf 
Related: #33892
Fixes: #35012

PR-URL: #35013
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
joesepi pushed a commit to joesepi/node that referenced this issue Jan 8, 2021
@watilde @joesepi
querystring: manage percent character at unescape
5366a2c 
Related: nodejs#33892
Fixes: nodejs#35012

PR-URL: nodejs#35013
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
querystring Issues and PRs related to the built-in querystring module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

querystring: manage percent character at unescape watilde/node
1 participant
@watilde