Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate error code #35029

Closed
Trott opened this issue Sep 3, 2020 · 2 comments · Fixed by #35031
Closed

Duplicate error code #35029

Trott opened this issue Sep 3, 2020 · 2 comments · Fixed by #35031
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core.

Comments

@Trott
Copy link
Member

Trott commented Sep 3, 2020

ERR_UNKNOWN_BUILTIN_MODULE is listed in the legacy section of the docs as added in 8.0.0 and removed in 9.0.0.... and also listed in the current section.

@Trott Trott added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Sep 3, 2020
@Trott
Copy link
Member Author

Trott commented Sep 3, 2020

Since the entries are (nearly) identical and we are using the error code, I'll delete the one in the legacy section.

@Trott
Copy link
Member Author

Trott commented Sep 3, 2020

#35031

@Trott Trott closed this as completed in 5e99b62 Sep 5, 2020
richardlau pushed a commit that referenced this issue Sep 7, 2020
Fixes: #35029

PR-URL: #35031
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
richardlau pushed a commit that referenced this issue Sep 7, 2020
Fixes: #35029

PR-URL: #35031
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
joesepi pushed a commit to joesepi/node that referenced this issue Jan 8, 2021
Fixes: nodejs#35029

PR-URL: nodejs#35031
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant