Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create public API replacement for process.binding('uv') #37951

Closed
addaleax opened this issue Mar 27, 2021 · 4 comments
Closed

Create public API replacement for process.binding('uv') #37951

addaleax opened this issue Mar 27, 2021 · 4 comments
Labels
deprecations Issues and PRs related to deprecations.

Comments

@addaleax
Copy link
Member

process.binding('uv') currently yields some information that I don’t think we expose as public API:

  1. uv.errname(), which can be trivially replaced by util.getSystemErrorName(), but also
  2. a full list of mapped UV error codes and getErrorMap() to access them in Map form (with their strerror()’ed description)

We could decide to drop the second bit from the API, but I think it’s worth exposing at least a full list of libuv error codes somewhere, and then implement a backwards-compatible replacement for process.binding('uv') in terms of that new API.

@addaleax addaleax added the deprecations Issues and PRs related to deprecations. label Mar 27, 2021
@addaleax
Copy link
Member Author

/cc @jasnell

@EladKeyshawn
Copy link

@addaleax Hey is this still relevant?

@EladKeyshawn
Copy link

EladKeyshawn commented Apr 5, 2021

I added a suggestion of implementation for this at #38101 I hope I understood the need correctly.

@addaleax
Copy link
Member Author

addaleax commented Apr 6, 2021

@EladKeyshawn I think something like that would work here, yes 👍

BethGriggs pushed a commit that referenced this issue Apr 15, 2021
PR-URL: #38101
Fixes: #37951
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue May 1, 2021
PR-URL: #38101
Fixes: #37951
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this issue May 8, 2021
PR-URL: #38101
Fixes: #37951
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecations Issues and PRs related to deprecations.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants