Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distributed CHANGELOG is useless #38025

Closed
targos opened this issue Apr 1, 2021 · 4 comments
Closed

distributed CHANGELOG is useless #38025

targos opened this issue Apr 1, 2021 · 4 comments
Labels
build Issues and PRs related to build files or the CI.

Comments

@targos
Copy link
Member

targos commented Apr 1, 2021

For example, download and extract https://nodejs.org/download/release/latest-v15.x/node-v15.13.0-darwin-x64.tar.xz

The CHANGELOG file in there is useless because it doesn't contain the v15.x changelog. It is a copy of the root CHANGELOG that only has relative links to files that don't exist in the distribution.
@targos targos added the build Issues and PRs related to build files or the CI. label Apr 1, 2021
@richardlau
Copy link
Member

FWIW this is how CHANGELOG.md ends up in the tar balls:

node/Makefile

Line 1130 in 3ef9562

cp CHANGELOG.md $(BINARYNAME)

@jasnell
Copy link
Member

jasnell commented Apr 1, 2021

The root changelog could definitely be updated with the full links.

@targos
Copy link
Member Author

targos commented Apr 1, 2021

I think it would be better to include the changelog file that corresponds de the release line

@richardlau richardlau mentioned this issue Apr 2, 2021
Closed
@richardlau
Copy link
Member

Pull request: #38033

@jasnell jasnell closed this as completed in 9cfb418 Apr 7, 2021
targos pushed a commit that referenced this issue May 1, 2021
@richardlau @targos
build: package release changelog for releases
079d90b 
Package the changelog for the release line as `CHANGELOG.md` when
building a release binary tarball.

PR-URL: #38033
Fixes: #38025
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: package release changelog for releases richardlau/node-1
3 participants
@jasnell @targos @richardlau