can't update url protocol when old protocol include '+'

[bluelovers]

Version

v16.6.1

Platform

windows 10 x64

Subsystem

No response

What steps will reproduce the bug?

let u = new URL( 'git+https://url-fake-hostname/zh-TW/scripts')

console.log(u)

u.protocol = 'http:';

console.assert(u.protocol !== 'git+https:', u.protocol)

How often does it reproduce? Is there a required condition?

100%

What is the expected behavior?

u.protocol = 'http:'

What do you see instead?

u.protocol = 'git+https:'

Additional information

in google chrome it can be update

https://stackoverflow.com/questions/68738015/why-cant-update-url-protocol-when-old-protocol-include-in-nodejs

[targos]

The behavior is correct according to the URL spec: https://url.spec.whatwg.org/#ref-for-scheme-state

If url’s scheme is not a special scheme and buffer is a special scheme, then return.

Because http is special scheme, and git+https isn't.

[bluelovers]

but Firefox, edge, chrome all support change it from git+https: to http:

[targos]

If they all support it, it's probably worth opening an issue in the spec repo: https://github.com/whatwg/url/issues

/cc @TimothyGu

[bluelovers]

another issue is origin is string 'null' in this case

[anonrig]

I agree with @targos. This is the correct behavior. URL spec mentions that in scheme state:

If url’s scheme is a special scheme and buffer is not a special scheme, then return.

another issue is origin is string 'null' in this case

@bluelovers Origin definition in the URL spec states that, if the scheme is not special or not blob, it will always return a new opaque origin (which is null). Referencing: https://url.spec.whatwg.org/#origin

I'm closing this issue. Please open a new issue, if you think there is a misinterpretation of the spec.