Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nominating Qingyu Deng (Ayase-252) as a collaborator #39912

Closed
gireeshpunathil opened this issue Aug 27, 2021 · 6 comments
Closed

nominating Qingyu Deng (Ayase-252) as a collaborator #39912

gireeshpunathil opened this issue Aug 27, 2021 · 6 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@gireeshpunathil
Copy link
Member

I would like to nominate Ayase-252 as a collaborator. They have been active and helping through many activities including code contributions, triaging and helping our users. Here are their contributions in a nutshell:

Commits in nodejs/node: https://github.com/nodejs/node/commits?author=Ayase-252
Pull requests and issues in nodejs/node: https://github.com/nodejs/node/issues?q=author:Ayase-252
Comments on pull requests and issues in nodejs/node: https://github.com/nodejs/node/issues?q=commenter:Ayase-252
Reviews on pull requests in nodejs/node: https://github.com/nodejs/node/pulls?q=reviewed-by:Ayase-252
Help provided to end-users and novice contributors: https://github.com/nodejs/help/issues?q=commenter:Ayase-252
Pull requests and issues opened throughout the Node.js organization: https://github.com/search?q=author:Ayase-252+org:nodejs
Comments on pull requests and issues throughout the Node.js organization: https://github.com/search?q=commenter:Ayase-252+org:nodejs
@gireeshpunathil gireeshpunathil added meta Issues and PRs related to the general management of the project. notable-change PRs with changes that should be highlighted in changelogs. and removed notable-change PRs with changes that should be highlighted in changelogs. labels Aug 27, 2021
@mhdawson
Copy link
Member

+1

@Trott
Copy link
Member

Trott commented Aug 27, 2021

GOVERNANCE.md says to @-mention collaborators so here's the dreaded mention: @nodejs/collaborators

The nomination passes automatically in a week unless someone says something to block it.

(Bear in mind that now 100+ people will get these notifications. If your comment can be an emoji reaction rather than a comment, please go with that. That said, a thoughtful supportive comment is always a good thing.)

@Ayase-252
Copy link
Member

Thank you for the nomination. I’m really honored.

@mcollina
Copy link
Member

Absolutely +1!

@iam-frankqiu
Copy link
Contributor

Thank you for the nomination. I’m really honored.

Congratulations! You deserve it.

@gireeshpunathil
Copy link
Member Author

this nomination is now passed. I will write to @Ayase-252 to plan for the onboarding.

Ayase-252 added a commit to Ayase-252/node that referenced this issue Sep 11, 2021
@Ayase-252
doc: add Ayase-252 to collaborators
95f5db8 
Fixes: nodejs#39912
@Ayase-252 Ayase-252 mentioned this issue Sep 11, 2021
Closed
BethGriggs pushed a commit that referenced this issue Sep 21, 2021
@Ayase-252 @BethGriggs
doc: add Ayase-252 to collaborators
ea2c387 
Fixes: #39912

PR-URL: #40078
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
BethGriggs pushed a commit that referenced this issue Sep 21, 2021
@Ayase-252 @BethGriggs
doc: add Ayase-252 to collaborators
9655329 
Fixes: #39912

PR-URL: #40078
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: add Ayase-252 to collaborators Ayase-252/node
6 participants
@mcollina @Trott @Ayase-252 @gireeshpunathil @mhdawson @iam-frankqiu