Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node JS Docs Typo #40228

Closed
warlock1996 opened this issue Sep 27, 2021 · 2 comments
Closed

Node JS Docs Typo #40228

warlock1996 opened this issue Sep 27, 2021 · 2 comments
Labels
doc Issues and PRs related to the documentations.

Comments

@warlock1996
Copy link
Contributor

NodeJS Docs Typo

  • latest-v14.x:
  • Windows 10 Pro:

https://nodejs.org/dist/latest-v14.x/docs/api/packages.html#packages_conditional_exports

it says

If a nested conditional does not have any mapping it will continue checking the remaining

it should be

If a nested condition does not have any mapping it will continue checking the remaining

@Ayase-252 Ayase-252 transferred this issue from nodejs/help Sep 27, 2021
@Ayase-252 Ayase-252 added the doc Issues and PRs related to the documentations. label Sep 27, 2021
@Ayase-252
Copy link
Member

Thank you for catching this. Do you want to send a PR?

If you are interested, see contribution guidance.
The relevent line is here
https://github.com/nodejs/node/blame/master/doc/api/packages.md#L562

@warlock1996
Copy link
Contributor Author

warlock1996 commented Sep 27, 2021 via email

targos pushed a commit that referenced this issue Oct 4, 2021
PR-URL: #40230
Fixes: #40228
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants