Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rfc: remove dtrace & etw support #43649

Closed
bnoordhuis opened this issue Jul 1, 2022 · 1 comment · Fixed by #43652
Closed

rfc: remove dtrace & etw support #43649

bnoordhuis opened this issue Jul 1, 2022 · 1 comment · Fixed by #43652
Labels
build Issues and PRs related to build files or the CI. smartos Issues and PRs related to the SmartOS platform. windows Issues and PRs related to the Windows platform.

Comments

@bnoordhuis
Copy link
Member

Do people actually use this? The commit history of the last ~5 years is full of mechanical changes but nothing that suggests actual user feedback, whether bug reports or feature requests. Some of the files haven't been touched since 2012!

The dtrace supports add a great deal of complexity to the build and makes upgrades harder. The etw support in turn leans heavily on the dtrace infrastructure. Ceteris paribus, I'd like to remove both.

cc @cjihrig - maybe you know?
@bnoordhuis bnoordhuis added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. smartos Issues and PRs related to the SmartOS platform. labels Jul 1, 2022
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Jul 1, 2022
@bnoordhuis
build: remove dtrace & etw support
e2189e8 
There are no clear indicators anyone is using the dtrace USDT probes.

ETW support is very intertwined with the dtrace infrastructure. It's not
clear if anyone uses ETW so to keep things simple it too is removed.

Fixes: nodejs#43649
@bnoordhuis bnoordhuis mentioned this issue Jul 1, 2022
Merged
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Jul 1, 2022
@bnoordhuis
build: remove dtrace & etw support
6b85106 
There are no clear indicators anyone is using the dtrace USDT probes.

ETW support is very intertwined with the dtrace infrastructure. It's not
clear if anyone uses ETW so to keep things simple it too is removed.

Fixes: nodejs#43649
@cjihrig
Copy link
Contributor

cjihrig commented Jul 3, 2022

I'm not aware of anyone using them or maintaining them - though I could be wrong.

bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Jul 11, 2022
@bnoordhuis
build: remove dtrace & etw support
8e9fa2e 
There are no clear indicators anyone is using the dtrace USDT probes.

ETW support is very intertwined with the dtrace infrastructure. It's not
clear if anyone uses ETW so to keep things simple it too is removed.

Fixes: nodejs#43649
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Jul 15, 2022
@bnoordhuis
build: remove dtrace & etw support
3f9c759 
There are no clear indicators anyone is using the dtrace USDT probes.

ETW support is very intertwined with the dtrace infrastructure. It's not
clear if anyone uses ETW so to keep things simple it too is removed.

Fixes: nodejs#43649
nodejs-github-bot pushed a commit that referenced this issue Jul 17, 2022
@bnoordhuis
build: remove dtrace & etw support
aa3a572 
There are no clear indicators anyone is using the dtrace USDT probes.

ETW support is very intertwined with the dtrace infrastructure. It's not
clear if anyone uses ETW so to keep things simple it too is removed.

Fixes: #43649

PR-URL: #43652
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Fyko pushed a commit to Fyko/node that referenced this issue Sep 15, 2022
@bnoordhuis @Fyko
build: remove dtrace & etw support
730fa9e 
There are no clear indicators anyone is using the dtrace USDT probes.

ETW support is very intertwined with the dtrace infrastructure. It's not
clear if anyone uses ETW so to keep things simple it too is removed.

Fixes: nodejs#43649

PR-URL: nodejs#43652
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. smartos Issues and PRs related to the SmartOS platform. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: remove dtrace & etw support bnoordhuis/io.js
2 participants
@bnoordhuis @cjihrig