Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The behavior of Buffer’s methods with an empty fill has not been documented. #45727

Closed
issuefiler opened this issue Dec 3, 2022 · 0 comments · Fixed by #45794
Closed

The behavior of Buffer’s methods with an empty fill has not been documented. #45727

issuefiler opened this issue Dec 3, 2022 · 0 comments · Fixed by #45794
Labels
buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.

Comments

@issuefiler
Copy link

issuefiler commented Dec 3, 2022 •
edited

Affected URL(s)

https://nodejs.org/api/buffer.html

Description of the problem

What happens when Buffer’s methods are called with the fill argument that is empty (a string, Buffer, array, et cetera.), has not been documented in Node.js 19.2.0’s documentation.

I’ve confirmed that Buffer.alloc(…, "", "UTF-8") and buffer.fill("") fill the Buffer with zero, which is expected but undocumented behavior.

I’m not talking about the indexOf or lastIndexOf methods.
@issuefiler issuefiler added the doc Issues and PRs related to the documentations. label Dec 3, 2022
@VoltrexKeyva VoltrexKeyva added the buffer Issues and PRs related to the buffer subsystem. label Dec 3, 2022
@marco-ippolito marco-ippolito mentioned this issue Dec 9, 2022
Merged
nodejs-github-bot pushed a commit that referenced this issue Dec 12, 2022
@marco-ippolito
doc: buffer.fill empty value
c6c3eea 
PR-URL: #45794
Fixes: #45727
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
ErickWendel pushed a commit to ErickWendel/node that referenced this issue Dec 12, 2022
@marco-ippolito @ErickWendel
doc: buffer.fill empty value
ec49bb1 
PR-URL: nodejs#45794
Fixes: nodejs#45727
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
targos pushed a commit that referenced this issue Dec 12, 2022
@marco-ippolito @targos
doc: buffer.fill empty value
bb16e9f 
PR-URL: #45794
Fixes: #45727
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
targos pushed a commit that referenced this issue Dec 13, 2022
@marco-ippolito @targos
doc: buffer.fill empty value
8a90f5c 
PR-URL: #45794
Fixes: #45727
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
danielleadams pushed a commit that referenced this issue Dec 30, 2022
@marco-ippolito @danielleadams
doc: buffer.fill empty value
9fd831b 
PR-URL: #45794
Fixes: #45727
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
danielleadams pushed a commit that referenced this issue Dec 30, 2022
@marco-ippolito @danielleadams
doc: buffer.fill empty value
a1b25c0 
PR-URL: #45794
Fixes: #45727
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
danielleadams pushed a commit that referenced this issue Jan 3, 2023
@marco-ippolito @danielleadams
doc: buffer.fill empty value
108220c 
PR-URL: #45794
Fixes: #45727
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
danielleadams pushed a commit that referenced this issue Jan 4, 2023
@marco-ippolito @danielleadams
doc: buffer.fill empty value
a17b6de 
PR-URL: #45794
Fixes: #45727
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
danielleadams pushed a commit that referenced this issue Jan 5, 2023
@marco-ippolito @danielleadams
doc: buffer.fill empty value
d0513f2 
PR-URL: #45794
Fixes: #45727
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: buffer.fill empty value marco-ippolito/node
2 participants
@issuefiler @VoltrexKeyva