Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nominating @KhafraDev as a collaborator #47388

Closed
anonrig opened this issue Apr 3, 2023 · 6 comments · Fixed by #47510
Closed

Nominating @KhafraDev as a collaborator #47388

anonrig opened this issue Apr 3, 2023 · 6 comments · Fixed by #47510
Labels
meta Issues and PRs related to the general management of the project.

Comments

@anonrig
Copy link
Member

anonrig commented Apr 3, 2023

I would like to nominate @KhafraDev as a collaborator. @KhafraDev has been doing some great work at the Undici repository for a long time, and recently they started contributing to the Node.js core repository.

Here is a summary of their contributions:

cc @nodejs/collaborators
@VoltrexKeyva VoltrexKeyva added the meta Issues and PRs related to the general management of the project. label Apr 3, 2023
@debadree25
Copy link
Member

I think this has passed now! 🎉❤️

@mcollina
Copy link
Member

@KhafraDev what timezone are you in? (so we can better schedule your onboarding).

@KhafraDev
Copy link
Member

KhafraDev commented Apr 10, 2023 •
edited

I'm in EST (GMT-5, typo)!

@srl295
Copy link
Member

srl295 commented Apr 10, 2023 •
edited

I'm in EST (GMT-4)!

EST would be GMT-5 I think you mean EDT!

But it's usually better to use the generic name and just say, ET or Eastern Time.

And, welcome and congrats!

@Trott
Copy link
Member

Trott commented Apr 10, 2023

I'll try to schedule something via email.

@srl295
Copy link
Member

srl295 commented Apr 10, 2023

I'm in EST (GMT-5, typo)!

If you are in GMT-5 year Round you might just say that. "EST" could be confusing if people think it's ET.

KhafraDev added a commit to KhafraDev/node that referenced this issue Apr 11, 2023
@KhafraDev
doc: add KhafraDev to collaborators
59f0750 
Fixes: nodejs#47388
@KhafraDev KhafraDev mentioned this issue Apr 11, 2023
Merged
targos pushed a commit that referenced this issue May 2, 2023
@KhafraDev @targos
doc: add KhafraDev to collaborators
9d30f46 
Fixes: #47388
PR-URL: #47510
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
danielleadams pushed a commit that referenced this issue Jul 6, 2023
@KhafraDev @danielleadams
doc: add KhafraDev to collaborators
0888c87 
Fixes: #47388
PR-URL: #47510
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this issue Jul 6, 2023
@KhafraDev @MoLow
doc: add KhafraDev to collaborators
a24d72a 
Fixes: nodejs#47388
PR-URL: nodejs#47510
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: add KhafraDev to collaborators KhafraDev/node
7 participants
@mcollina @Trott @srl295 @anonrig @debadree25 @KhafraDev @VoltrexKeyva