Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL parser behaviour change in 18.16.0 #47555

Closed
nabinked opened this issue Apr 14, 2023 · 8 comments · Fixed by #47598
Closed

URL parser behaviour change in 18.16.0 #47555

nabinked opened this issue Apr 14, 2023 · 8 comments · Fixed by #47598
Assignees
@lemire @anonrig
Labels
confirmed-bug Issues with confirmed bugs. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@nabinked
Copy link

18.15.0

new URL(HTTP://AMAZON.COM).href gives http://amazon.com/

18.16.0
new URL(HTTP://AMAZON.COM).href gives http://amaZon.com/

It seems the capital letter Z is not lower cased. Is that expected or is it a regression ?
@nabinked nabinked changed the title URL Parser behaviour change in 18.16.0 URL parser behaviour change in 18.16.0 Apr 14, 2023
@KhafraDev KhafraDev added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Apr 14, 2023
@KhafraDev
Copy link
Member

cc @nodejs/url

@Trott
Copy link
Member

Trott commented Apr 14, 2023 •
edited

I'm able to reproduce this:

➜  ~ node
Welcome to Node.js v18.16.0.
Type ".help" for more information.
> new URL('HTTP://AMAZON.COM').href
'http://amaZon.com/'
>

Node.js 18.16.0 uses Ada for parsing while 18.15.0 does not, so I strongly suspect this is either a bug in Ada or a bug in Node.js that was introduced as part of the change set to include Ada.

@anonrig @lemire

@MoLow MoLow added the confirmed-bug Issues with confirmed bugs. label Apr 14, 2023
@Trott
Copy link
Member

Trott commented Apr 14, 2023

Node.js 19.7.0 and newer has this same issue. 19.6.1 does not. And again, 19.7.0 is the version where Ada is introduced.

@Trott Trott added v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. v19.x labels Apr 14, 2023
@anonrig
Copy link
Member

anonrig commented Apr 14, 2023

I will fix this in Ada. Thanks for reporting.

@lemire
Copy link
Member

lemire commented Apr 14, 2023

That's odd.

@lemire
Copy link
Member

lemire commented Apr 14, 2023

Wow.

@anonrig
Copy link
Member

anonrig commented Apr 14, 2023

@lemire's pull request fixed this in Ada. We'll release a new version.

@anonrig anonrig mentioned this issue Apr 17, 2023
Merged
@anonrig
Copy link
Member

anonrig commented Apr 17, 2023

Ada v2.1.0 will fix this issue.

@fuxingloh fuxingloh mentioned this issue Apr 25, 2023
Closed
@fvictorio fvictorio mentioned this issue May 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lemire lemire

@anonrig anonrig

Labels
confirmed-bug Issues with confirmed bugs. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: update ada to 2.1.0 nodejs/node
6 participants
@lemire @Trott @anonrig @nabinked @MoLow @KhafraDev