Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hardhat compile randomly and quietly stops before compiling contracts #3877

Closed
sebastiendan opened this issue Apr 24, 2023 · 10 comments · Fixed by #4075
Closed

hardhat compile randomly and quietly stops before compiling contracts #3877

sebastiendan opened this issue Apr 24, 2023 · 10 comments · Fixed by #4075
Assignees
@fvictorio
Labels
status:blocked Blocked by other issues or external reasons type:bug Something isn't working

Comments

@sebastiendan
Copy link

sebastiendan commented Apr 24, 2023 •
edited by fvictorio

Edit by @fvictorio: Hardhat 2.16.1 should this problem.

Version of Hardhat

2.14.0

What happened?

npx hardhat compile sometimes goes on with compiling contracts and sometimes (seems totally random) silently stops at the Downloading compiler ... step before any contracts are actually compiled. This issue is reproducible with no contracts already compiled and in docker.

Minimal reproduction steps

Here's a simple repository where you can observe the problem: repo.

This CI workflow run shows in the logs that the compilation didn't happen: log.

In addition, one can run the docker container in interactive mode and manually run the build command to see that, again, the command sometimes doesn't build nor throws an error but simply quietly stops without compiling (same output as the CI log above):

  • Run the container in interactive mode: docker run --rm -it ghcr.io/sebastiendan/hardhat-compile-issue:main bash
  • Run the compile command: npm run build
  • Observe sometimes an actual compilation, sometimes a quiet stop in the command execution
    (run the above multiple times by exiting the container and re-running the two commands above)

Search terms

no compilation
@fuxingloh
Copy link

See:

This is due to a regression in the latest node versions 18 and 20. Somewhere after "Downloading compiler list for platform" when trying to a compiler, it failed to download it and failed silently.

Try to use a node version other than the latest. I'm surprised the node team hasn't done a release yet since this is a widespread issue.

@stefiix92
Copy link

@fuxingloh thanks for pointing that out, I tried node 18.12.1 and the issue disappeared!

@asaj asaj mentioned this issue Apr 25, 2023
Merged
@sebastiendan sebastiendan mentioned this issue Apr 25, 2023
Closed
4 tasks
@sebastiendan
Copy link
Author

@fuxingloh I can confirm it works with the 18.15.0-slim docker tag of node 👍

@fvictorio
Copy link
Member

Wow, this is so weird. Thanks everyone for the info.

I still don't quite understand why and when this happens, but it's good to know that changing the version of node fixes the issue.

@sebastiendan I'm going to edit your issue so this information shows up first for people landing here.

@fvictorio fvictorio pinned this issue Apr 25, 2023
@jubeira
Copy link

jubeira commented Apr 25, 2023 •
edited

FWIW, Github actions is currently using 18.16.0 in Ubuntu 20 / 22 (latest) if the Node version is specified just as 18: actions/runner-images@af6dd20.

Specifying a different minor version (e.g node-version: 18.15) indeed solves the problem.

@jubeira jubeira mentioned this issue Apr 25, 2023
Merged
11 tasks
ryscheng added a commit to hypercerts-org/hypercerts that referenced this issue Apr 26, 2023
@ryscheng
fix: re-adding contracts/ back into the monorepo
d5c011a 
* Separate build:deploy command for compiling for deployment
* Fixing our node version to 18.15.0 for now while we wait for a fix for
  NomicFoundation/hardhat#3877
This was referenced Apr 26, 2023
Open
Closed
ryscheng added a commit to hypercerts-org/hypercerts that referenced this issue Apr 26, 2023
@ryscheng
fix: re-adding contracts/ back into the monorepo
cdd15f0 
* Separate build:deploy command for compiling for deployment
* Fixing our node version to 18.15.0 for now while we wait for a fix for
  NomicFoundation/hardhat#3877
ryscheng added a commit to hypercerts-org/hypercerts that referenced this issue Apr 26, 2023
@ryscheng
fix: re-adding contracts/ back into the monorepo
77df842 
* Separate build:deploy command for compiling for deployment
* Fixing our node version to 18.15.0 for now while we wait for a fix for
  NomicFoundation/hardhat#3877
ryscheng added a commit to hypercerts-org/hypercerts that referenced this issue Apr 26, 2023
@ryscheng
fix: re-adding contracts/ back into the monorepo (#595)
2aa2410 
* Separate build:deploy command for compiling for deployment
* Fixing our node version to 18.15.0 for now while we wait for a fix for
  NomicFoundation/hardhat#3877
@halaprix halaprix mentioned this issue Apr 26, 2023
Merged
@portuu3 portuu3 mentioned this issue Apr 26, 2023
Merged
2 tasks
asaj added a commit to hyperlane-xyz/hyperlane-monorepo that referenced this issue Apr 26, 2023
@asaj
Use node 16 when compiling contract types (#2146)
5f72e7f 
### Description

To address NomicFoundation/hardhat#3877

Also reverts #2140
@not-thing not-thing mentioned this issue Apr 27, 2023
Merged
@geoknee geoknee mentioned this issue Apr 27, 2023
Merged
geoknee added a commit to statechannels/go-nitro that referenced this issue Apr 27, 2023
@geoknee
set node-version to 18.15.0
1e3e3dd 
NomicFoundation/hardhat#3877
@fvictorio fvictorio added status:blocked Blocked by other issues or external reasons and removed status:triaging labels Apr 27, 2023
@georgi-l95 georgi-l95 mentioned this issue Apr 28, 2023
Merged
2 tasks
@elopez elopez mentioned this issue Apr 28, 2023
Open
0xalpharush added a commit to crytic/medusa that referenced this issue Apr 28, 2023
@0xalpharush
ci: pin node version to 18.5
b4fda2f 
Fixes flaky hardhat compilation until a node release is made
NomicFoundation/hardhat#3877
@0xalpharush 0xalpharush mentioned this issue Apr 28, 2023
Merged
@frangio frangio mentioned this issue Apr 28, 2023
Merged
@hazim-j hazim-j mentioned this issue May 1, 2023
Merged
@fvictorio
Copy link
Member

Honestly, I thought they were going to release a fix sooner. I'll see if there's some workaround we can implement on our side.

@fvictorio fvictorio added the type:bug Something isn't working label Jun 22, 2023
felipetavares added a commit to immutable/wallet-contracts that referenced this issue Jun 23, 2023
@felipetavares
Use node 18.15
4458354 
NomicFoundation/hardhat#3877
@sink772 sink772 mentioned this issue Jun 23, 2023
Merged
@fvictorio fvictorio self-assigned this Jun 26, 2023
michalinacienciala added a commit to threshold-network/solidity-contracts that referenced this issue Jun 27, 2023
@michalinacienciala
Set Node.js version to 18.15.0
9dd0d2f 
We want to fix problem with the `yarn build` (`hardhat compile`) command
sometimes not generating expected artifacts. The problem is caused by the
process silently quitting, which is related to the used version of Node (as
descibed in NomicFoundation/hardhat#3877). We've confirmed the problem is
reproducible on `v18.16.0`, now we're downgrading to `v18.15.0` to fix the
issue.
@michalinacienciala michalinacienciala mentioned this issue Jun 27, 2023
Merged
pdyraga added a commit to threshold-network/solidity-contracts that referenced this issue Jun 27, 2023
@pdyraga
Merge pull request #147 from threshold-network/use-yarn-18.5.0-in-sli…
9837c6d 
…ther

Set Node.js version to 18.15.0

We want to fix problem with the yarn build (hardhat compile) command sometimes not generating expected artifacts. The problem is caused by the process silently quitting, which is related to the used version of Node (as descibed in NomicFoundation/hardhat#3877). We've confirmed the problem is reproducible on v18.16.0, now we're downgrading to v18.15.0 to fix the issue.
@fvictorio fvictorio mentioned this issue Jun 27, 2023
Merged
@fvictorio
Copy link
Member

Hi everyone, we just released Hardaht v2.16.1 which should fix this problem.

@felicio felicio mentioned this issue Jun 29, 2023
Merged
4 tasks
@leric7 leric7 mentioned this issue Jun 29, 2023
Merged
2 tasks
@ScreamingHawk ScreamingHawk mentioned this issue Jul 3, 2023
Merged
@fvictorio fvictorio unpinned this issue Jul 4, 2023
@fvictorio fvictorio mentioned this issue Jul 4, 2023
Closed
This was referenced Jul 7, 2023
Merged
Merged
Merged
outerlook pushed a commit to usherlabs/logstore-mirror that referenced this issue Jul 10, 2023
@victorshevtsov
hotfix hardhat compile randomly and quietly stops in docker
157c70c 
NomicFoundation/hardhat#3877
@coreyar coreyar mentioned this issue Jul 12, 2023
Merged
@nytzuga nytzuga mentioned this issue Jul 14, 2023
Merged
@misicnenad misicnenad mentioned this issue Aug 2, 2023
Closed
@veaceslavdoina veaceslavdoina mentioned this issue Aug 7, 2023
Merged
@noisekit noisekit mentioned this issue Aug 11, 2023
Closed
sirpy added a commit to GoodDollar/GoodCollective that referenced this issue Aug 17, 2023
@sirpy
wip: fix hardhat CI issue NomicFoundation/hardhat#3877
8c6335d
@fleupold fleupold mentioned this issue Aug 25, 2023
Merged
fleupold added a commit to cowprotocol/contracts that referenced this issue Aug 25, 2023
@fleupold
Fix CD by pinning older docker image (#60)
9a672fb 
When currently building the docker image of the contract, we are not
including any artefacts, which - when running any hardhat script -
yields the following error:

```
HardhatError: HH700: Artifact for contract "src/contracts/interfaces/IERC20.sol:IERC20" not found. 
```

When looking at the build history we can see a subtle difference between
a build [that is
working](https://github.com/cowprotocol/contracts/actions/runs/5974729999/job/16209505930#step:5:253)
and [one that
isn't](https://github.com/cowprotocol/contracts/actions/runs/5975825913/job/16212645253#step:5:248):

```
#11 0.750 $ hardhat compile --force
#11 4.073 Warning: unable to recover token list from 1inch
#11 4.364 Downloading compiler 0.7.6
#11 4.826 Downloading compiler 0.7.6
**#11 17.88 Compiled 58 Solidity files successfully**
#11 18.27 $ tsc && tsc -p tsconfig.lib.esm.json && tsc -p tsconfig.lib.commonjs.json
```

vs

```
#11 0.860 $ hardhat compile --force
#11 4.335 Warning: unable to recover token list from 1inch
#11 4.646 Downloading compiler 0.7.6
#11 5.211 $ tsc && tsc -p tsconfig.lib.esm.json && tsc -p tsconfig.lib.commonjs.json
```

The latter doesn't seem to compile any artefacts. According to
NomicFoundation/hardhat#3877 this is due to a
URL parser behavior change in Node 18.16 that can lead to silent
Download failures. It's still no entirely clear to me why it sometimes
works (maybe because of some intermittent error)

### Test Plan

I hope this works, or at least tells us why the files are not being
compiled
@nikugogoi nikugogoi mentioned this issue Sep 6, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fvictorio fvictorio

Labels
status:blocked Blocked by other issues or external reasons type:bug Something isn't working
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consume downloads instead of piping them NomicFoundation/hardhat
8 participants
@freeatnet @fvictorio @jubeira @fuxingloh @sebastiendan @jtakalai @stefiix92 @bdovh