test runner: dors the after hook run After failure ? #50901
Labels
doc
Issues and PRs related to the documentations.
good first issue
Issues that are suitable for first-time contributors.
test_runner
Comments
|
Hooks are executed even if tests fail. PRs to documentation are welcomed |
marco-ippolito
added
test_runner
good first issue
ognjenjevremovic
added a commit
to ognjenjevremovic/node
that referenced
this issue
Jan 19, 2024
The `after` hook now explicitly mentions that it is executed once after all the tests in a test suite have completed, regardless of whether the tests passed or failed. This ensures that cleanup tasks or actions specified in the after hook are guaranteed to run. Refs: nodejs#50901
ognjenjevremovic
added a commit
to ognjenjevremovic/node
that referenced
this issue
Jan 19, 2024
The `afterEach` hook is now documented to be executed after each individual test in a test suite, irrespective of whether the test passed or failed. Developers can rely on this hook for performing cleanup or resetting state after each test. Refs: nodejs#50901
ognjenjevremovic
added a commit
to ognjenjevremovic/node
that referenced
this issue
Jan 19, 2024
Refined the language in the documentation for the `after` and `afterEach` hooks to enhance clarity. Replaced instances of "note that" with more direct and concise language for better readability. Refs: nodejs#50901
|
Hello everyone 👋 I'm excited to share that I've addressed the concerns raised in this issue regarding the documentation for the As a first-time contributor to the Node.js (runtime), I'm thrilled to be a part of this amazing community. I've ensured that the changes adhere to the project's documentation style guide and have addressed linting warnings for improved clarity. Feel free to review the pull request, provide feedback, or let me know if there's anything else I can do to enhance the contribution. I'm looking forward to being a more active part of the Node.js community! 🙂 |
ryancanulla
added a commit
to ryancanulla/node
that referenced
this issue
Jan 20, 2024
ognjenjevremovic
added a commit
to ognjenjevremovic/node
that referenced
this issue
Jan 20, 2024
Refined the documentation for the `after` and `afterEach` hooks to enhance clarity. Removed redundant information and retained the essential details. The revised note now explicitly states that the `after` and `afterEach` hooks are guaranteed to run, even if tests within the suite fail. Refs: nodejs#50901
ognjenjevremovic
added a commit
to ognjenjevremovic/node
that referenced
this issue
Jan 20, 2024
Adjusted line lengths in the documentation to adhere to the maximum allowed limit of 80 characters. This change resolves the linting error. Refs: nodejs#50901
nodejs-github-bot
pushed a commit
that referenced
this issue
Feb 3, 2024
The `after` hook now explicitly mentions that it is executed once after all the tests in a test suite have completed, regardless of whether the tests passed or failed. This ensures that cleanup tasks or actions specified in the after hook are guaranteed to run. Refs: #50901 PR-URL: #51523 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this issue
Feb 9, 2024
The `after` hook now explicitly mentions that it is executed once after all the tests in a test suite have completed, regardless of whether the tests passed or failed. This ensures that cleanup tasks or actions specified in the after hook are guaranteed to run. Refs: nodejs#50901 PR-URL: nodejs#51523 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos
pushed a commit
that referenced
this issue
Feb 15, 2024
The `after` hook now explicitly mentions that it is executed once after all the tests in a test suite have completed, regardless of whether the tests passed or failed. This ensures that cleanup tasks or actions specified in the after hook are guaranteed to run. Refs: #50901 PR-URL: #51523 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this issue
Feb 19, 2024
The `after` hook now explicitly mentions that it is executed once after all the tests in a test suite have completed, regardless of whether the tests passed or failed. This ensures that cleanup tasks or actions specified in the after hook are guaranteed to run. Refs: nodejs#50901 PR-URL: nodejs#51523 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
|
Fixed by #51523 |
richardlau
pushed a commit
that referenced
this issue
Mar 25, 2024
The `after` hook now explicitly mentions that it is executed once after all the tests in a test suite have completed, regardless of whether the tests passed or failed. This ensures that cleanup tasks or actions specified in the after hook are guaranteed to run. Refs: #50901 PR-URL: #51523 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
richardlau
pushed a commit
that referenced
this issue
Mar 25, 2024
The `after` hook now explicitly mentions that it is executed once after all the tests in a test suite have completed, regardless of whether the tests passed or failed. This ensures that cleanup tasks or actions specified in the after hook are guaranteed to run. Refs: #50901 PR-URL: #51523 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Affected URL(s)
https://nodejs.org/api/test.html#afterfn-options
Description of the problem
In the document,it is unclear wether the after hook is run when the test did failed.
Same for the afterEach hook.
The text was updated successfully, but these errors were encountered: