Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky - addons.worker-buffer-callback.test-free-called #51003

Closed
mhdawson opened this issue Dec 1, 2023 · 1 comment · Fixed by #51013
Closed

Flaky - addons.worker-buffer-callback.test-free-called #51003

mhdawson opened this issue Dec 1, 2023 · 1 comment · Fixed by #51013
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.

Comments

@mhdawson
Copy link
Member

mhdawson commented Dec 1, 2023

Test

addons.worker-buffer-callback.test-free-called

Platform

No response

Console output

fail (1)

---
duration_ms: 354.138
exitcode: 1
severity: fail
...

Build links

Additional information

No response
@mhdawson mhdawson added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Dec 1, 2023
MrJithil added a commit to MrJithil/node that referenced this issue Dec 2, 2023
@MrJithil
fix: resolve flakiness in worker*.test-free-called
29d2b2a 
Fixes: nodejs#51003

The issue arises from the `getFreeCallCount()` function yielding the
initial value of 0. Upon instantiation of the `Worker` object, it
increments to 1. In the case of this flaky test, if the creation of the
`Worker` object is faster, the subsequent `getFreeCallCount()` call
always returns 1 instead of the expected 0.
@MrJithil MrJithil mentioned this issue Dec 2, 2023
Merged
MrJithil added a commit to MrJithil/node that referenced this issue Dec 2, 2023
@MrJithil
test: resolve flakiness in worker*.test-free-called
77db520 
Fixes: nodejs#51003

The issue arises from the `getFreeCallCount()` function yielding the
initial value of 0. Upon instantiation of the `Worker` object, it
increments to 1. In the case of this flaky test, if the creation of the
`Worker` object is faster, the subsequent `getFreeCallCount()` call
always returns 1 instead of the expected 0.
MrJithil added a commit to MrJithil/node that referenced this issue Dec 2, 2023
@MrJithil
test: fix flakiness in worker*.test-free-called
ecd8ad5 
Fixes: nodejs#51003
The issue arises from the `getFreeCallCount()` function yielding the
initial value of 0. Upon instantiation of the `Worker` object, it
increments to 1. In the case of this flaky test, if the creation of the
`Worker` object is faster, the subsequent `getFreeCallCount()` call
always returns 1 instead of the expected 0.
MrJithil added a commit to MrJithil/node that referenced this issue Dec 2, 2023
@MrJithil
test: fix flakiness in worker*.test-free-called
164741e 
Fixes: nodejs#51003
The issue arises from the `getFreeCallCount()` function yielding the
initial value of 0. Upon instantiation of the `Worker` object, it
increments to 1. In the case of this flaky test, if the creation of the
`Worker` object is faster, the subsequent `getFreeCallCount()` call
always returns 1 instead of the expected 0.
MrJithil added a commit to MrJithil/node that referenced this issue Dec 2, 2023
@MrJithil
test: fix flakiness in worker*.test-free-called
c306d18 
Fixes: nodejs#51003
The issue arises from the `getFreeCallCount()` function yielding the
initial value of 0. Upon instantiation of the `Worker` object, it
increments to 1. In the case of this flaky test, if the creation of the
`Worker` object is faster, the subsequent `getFreeCallCount()` call
always returns 1 instead of the expected 0.
MrJithil added a commit to MrJithil/node that referenced this issue Dec 9, 2023
@MrJithil
test: fix flakiness in worker*.test-free-called
2bf498c 
The issue arises from the `getFreeCallCount()` function yielding the
initial value of 0. Upon instantiation of the `Worker` object, it
increments to 1. In the case of this flaky test, if the creation of the
`Worker` object is faster, the subsequent `getFreeCallCount()` call
always returns 1 instead of the expected 0.

Fixes: nodejs#51003
@mhdawson
Copy link
Member Author

again - https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix72-ppc64/49531/

nodejs-github-bot pushed a commit that referenced this issue Dec 19, 2023
@MrJithil
test: fix flakiness in worker*.test-free-called
64f7d0e 
The issue arises from the `getFreeCallCount()` function yielding the
initial value of 0. Upon instantiation of the `Worker` object, it
increments to 1. In the case of this flaky test, if the creation of the
`Worker` object is faster, the subsequent `getFreeCallCount()` call
always returns 1 instead of the expected 0.

Fixes: #51003
PR-URL: #51013
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this issue Jan 2, 2024
@MrJithil @RafaelGSS
test: fix flakiness in worker*.test-free-called
d7c2572 
The issue arises from the `getFreeCallCount()` function yielding the
initial value of 0. Upon instantiation of the `Worker` object, it
increments to 1. In the case of this flaky test, if the creation of the
`Worker` object is faster, the subsequent `getFreeCallCount()` call
always returns 1 instead of the expected 0.

Fixes: #51003
PR-URL: #51013
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this issue Mar 25, 2024
@MrJithil @richardlau
test: fix flakiness in worker*.test-free-called
efd6630 
The issue arises from the `getFreeCallCount()` function yielding the
initial value of 0. Upon instantiation of the `Worker` object, it
increments to 1. In the case of this flaky test, if the creation of the
`Worker` object is faster, the subsequent `getFreeCallCount()` call
always returns 1 instead of the expected 0.

Fixes: #51003
PR-URL: #51013
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: resolve flakiness in worker*.test-free-called MrJithil/node
1 participant
@mhdawson