-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression in 21.4.0 when using esm
package
#51081
Labels
fs
Issues and PRs related to the fs subsystem / file system.
regression
Issues related to regressions.
v21.x
v21.x Issues that can be reproduced on v21.x or PRs targeting the v21.x-staging branch.
Comments
jeremymeng
added a commit
to jeremymeng/azure-sdk-for-js
that referenced
this issue
Dec 14, 2023
because of nodejs/node#51081 Revert "[EngSys] unpin NodeTestVersion of 21.2.0 (Azure#27999)" This reverts commit 884d750.
jeremymeng
added a commit
to Azure/azure-sdk-for-js
that referenced
this issue
Dec 14, 2023
Because of a regression in v21.4.0, running our tests with `esm` package is broken. nodejs/node#51081 Revert "[EngSys] unpin NodeTestVersion of 21.2.0 (#27999)" This reverts commit 884d750.
jeremymeng
added a commit
to jeremymeng/node
that referenced
this issue
Jan 4, 2024
This reverts commit 95b1989. It appears that the workaround is still needed: issue nodejs#51081
jeremymeng
added a commit
to jeremymeng/node
that referenced
this issue
Jan 5, 2024
This reverts commit 95b1989. It appears that the workaround is still needed: issue nodejs#51081
targos
pushed a commit
to jeremymeng/node
that referenced
this issue
Feb 20, 2024
This reverts commit 95b1989. It appears that the workaround is still needed: issue nodejs#51081
marco-ippolito
pushed a commit
to jeremymeng/node
that referenced
this issue
Feb 26, 2024
This reverts commit 95b1989. It appears that the workaround is still needed: issue nodejs#51081
marco-ippolito
pushed a commit
to jeremymeng/node
that referenced
this issue
Feb 27, 2024
This reverts commit 95b1989. It appears that the workaround is still needed: issue nodejs#51081
marco-ippolito
pushed a commit
that referenced
this issue
Feb 27, 2024
marco-ippolito
pushed a commit
that referenced
this issue
Feb 29, 2024
This is also reproducible in node 22.x.x, 🙇 so revert needs to be applied there I think. |
This isn't really a bug. We changed some undocumented internals that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fs
Issues and PRs related to the fs subsystem / file system.
regression
Issues related to regressions.
v21.x
v21.x Issues that can be reproduced on v21.x or PRs targeting the v21.x-staging branch.
Version
v21.4.0
Platform
Linux codespaces-8a914d 6.2.0-1016-azure #16~22.04.1-Ubuntu SMP Tue Oct 10 17:11:51 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Subsystem
No response
What steps will reproduce the bug?
test.js
with the following contentHow often does it reproduce? Is there a required condition?
always
What is the expected behavior? Why is that the expected behavior?
same as in v21.3.0
What do you see instead?
content of
esm.js
is dumped to console for a TypeErrorAdditional information
No response
The text was updated successfully, but these errors were encountered: