Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmentation fault when allocating memory in WASM #51303

Open
orsett0 opened this issue Dec 28, 2023 · 1 comment
Open

Segmentation fault when allocating memory in WASM #51303

orsett0 opened this issue Dec 28, 2023 · 1 comment
Labels
wasm Issues and PRs related to WebAssembly.

Comments

@orsett0
Copy link

orsett0 commented Dec 28, 2023

Version

v21.5.0

Platform

Linux shortplay 6.1.57-gentoo-x86_64 #2 SMP PREEMPT_DYNAMIC Wed Nov 29 15:55:15 CET 2023 x86_64 AMD Ryzen 5 2500U with Radeon Vega Mobile Gfx AuthenticAMD GNU/Linux

Subsystem

WASI

What steps will reproduce the bug?

Compile the following code with rustc --target=wasm32-wasi main.rs

fn main() {
    let mut total_size: u32 = 0;

    let mut s1 = "".to_owned();
    for _ in 0..8192 {
        for _ in 0..1024 {
            s1 = s1 + "A";
            total_size += 1;
        }
    }
    println!("Successifully allocated {} bytes for s1", total_size);

    let mut s2 = "".to_owned();
    for _ in 0..8198 {
        for _ in 0..1024 {
            s2 = s2 + "A";
            total_size += 1;
        }
        print!("\rSuccessifully allocated {} bytes for s2", total_size);
    }

    println!("\nGoodbye!");
}

This is my index.js:

import { readFileSync } from 'node:fs';
import { WASI } from 'wasi';

(async function () {
  const wasi = new WASI({
    version: 'preview1'
  });

  wasi.start(
    await WebAssembly.instantiate(
      await WebAssembly.compile(readFileSync('./main.wasm')),
      wasi.getImportObject()
    )
  );

})().then(() => console.log("Done"));

How often does it reproduce? Is there a required condition?

Every time you run the code.

This issue appears every time WASM requires to allocate more than (around) 8MiB.

What is the expected behavior? Why is that the expected behavior?

The expected behavior is for no segmentation fault to occur.

What do you see instead?

Segmentation fault, after the execution of the rust code.

Additional information

I noticed this issue in a project I'm working on. It that project WASI fails when trying to read a file larger than around 8MiB.

Unfortunately, I'm unable to identify the exact amount of memory required to trigger this bug, given that it changes based on a lot of different factors, which I wasn't able to identify.

Another thing, in the code I provided the bug is only triggered if you:

  • Excede a defined amount of memory for at least one variable
  • Print any variable.

I found this issue on another machine I don't have access to right now. It's running Arch Linux and Node.js v21.4.0.

Also, on this machine I'm running rustc v1.74.1

@tniessen tniessen added the wasm Issues and PRs related to WebAssembly. label Jan 3, 2024
@RulerOfCakes
Copy link
Contributor

Some additional observations:

  • Simply printing anything is enough to trigger the bug.
  • The exact amount doesn't seem to be consistent, the same thing happens with a vec but also in different ranges. For example the following code:
fn main() {
    let vc: Vec<u32> = vec![0; 7855 * 1024];

    println!(
        "\rSize of new vec allocated: {} bytes",
        std::mem::size_of::<Vec<u32>>() + std::mem::size_of::<u32>() * vc.capacity()
    );
}

this vec memory allocation only triggers the bug starting at capacity 7855*1024 and above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasm Issues and PRs related to WebAssembly.
Projects
None yet
Development

No branches or pull requests

3 participants