Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominating Cheng Zhao (@zcbenz) as a collaborator #51479

Closed
anonrig opened this issue Jan 15, 2024 · 7 comments
Closed

Nominating Cheng Zhao (@zcbenz) as a collaborator #51479

anonrig opened this issue Jan 15, 2024 · 7 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@anonrig
Copy link
Member

anonrig commented Jan 15, 2024

I'd like to nominate Cheng Zhao (@zcbenz) as a Node.js collaborator. I'm quite shocked to learn that they're not a collaborator. The contributions speak for themselves.

Commits authored on nodejs/node: https://github.com/search?q=repo%3Anodejs%2Fnode+author%3Azcbenz&type=commits
Pull requests opened: https://github.com/search?q=repo%3Anodejs%2Fnode+author%3Azcbenz&type=pullrequests
Issues opened: https://github.com/search?q=repo%3Anodejs%2Fnode+author%3Azcbenz&type=issues
Comments on pull requests and issues throughout the Node.js organization: https://github.com/search?q=org%3Anodejs+commenter%3Azcbenz&type=pullrequests

cc @nodejs/collaborators

@VoltrexKeyva VoltrexKeyva added the meta Issues and PRs related to the general management of the project. label Jan 15, 2024
@anonrig
Copy link
Member Author

anonrig commented Jan 23, 2024

Congrats! Welcome to Node.js project, @zcbenz.

@nodejs/tsc The deadline have passed. Can an available person schedule an onboarding session with Cheng?

@anonrig
Copy link
Member Author

anonrig commented Feb 2, 2024

ping @nodejs/tsc

@mcollina
Copy link
Member

mcollina commented Feb 2, 2024

Where are you based @zcbenz? If EU working ours would work for you, I can schedule one.

@zcbenz
Copy link
Contributor

zcbenz commented Feb 4, 2024

Thanks for taking this! My timezone is JST, any time between 18:30 and 22:00 JST should work for me next week, you can send an invitation to zcbenz @ gmail.com if there is a time working for you.

@mcollina
Copy link
Member

mcollina commented Feb 4, 2024

Invite sent for Tuesday. If there are other TSC members or collaborators that want to tag along, lmk.

@richardlau
Copy link
Member

Invite sent for Tuesday. If there are other TSC members or collaborators that want to tag along, lmk.

FYI you may not be able to check that they can start a CI as it may still be locked down for the upcoming security release.

@mcollina
Copy link
Member

mcollina commented Feb 4, 2024

Ah true. I'll move to the following week then.

zcbenz added a commit to zcbenz/node that referenced this issue Feb 20, 2024
@zcbenz zcbenz closed this as completed in 079c346 Feb 20, 2024
marco-ippolito pushed a commit that referenced this issue Feb 26, 2024
Fixes: #51479
PR-URL: #51812
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
rdw-msft pushed a commit to rdw-msft/node that referenced this issue Mar 20, 2024
Fixes: nodejs#51479
PR-URL: nodejs#51812
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau pushed a commit that referenced this issue Mar 25, 2024
Fixes: #51479
PR-URL: #51812
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau pushed a commit that referenced this issue Mar 25, 2024
Fixes: #51479
PR-URL: #51812
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants