-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http module documented default behavior only triggered if undocumented option is set #53035
Comments
Thanks! If you'd like, you can submit a PR updating the documentation, and the team will be more than happy to review :-) |
I'd like to submit a PR but I'm not sure about which way to go about it. Should I somehow add that to the documentation, and separately push it for
Not sure which way this should go right now. |
@nodejs/http |
@earslap The omission is not intentional. The author of the PR was supposed to sent a fix-up PR for docs (and types) but never did. See: #47732 (comment) You are more than welcome to send your PR. |
PR-URL: nodejs#53396 Fixes: nodejs#53035 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: nodejs#53396 Fixes: nodejs#53035 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Affected URL(s)
https://nodejs.org/api/http.html#responsewritechunk-encoding-callback
Description of the problem
For the http module, the documentation for
response.write
says:However this is not the default behavior. By default, nodejs swallows the provided body and prints the debug message (enabled by
NODE_DEBUG=http
):The documented behavior (throwing ERR_HTTP_BODY_NOT_ALLOWED) happens only when
rejectNonStandardBodyWrites
option is set totrue
while creating a server withcreateServer
. However this option is not documented, it does not exist in@node/types
either.The text was updated successfully, but these errors were encountered: