Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Event: 'unhandledRejection' code example not borked #5644

Closed
jmm opened this issue Mar 10, 2016 · 7 comments
Closed

doc: Event: 'unhandledRejection' code example not borked #5644

jmm opened this issue Mar 10, 2016 · 7 comments
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. process Issues and PRs related to the process subsystem.

Comments

@jmm
Copy link
Contributor

jmm commented Mar 10, 2016

https://nodejs.org/api/process.html#process_event_unhandledrejection

somePromise.then((res) => {
  return reportToUser(JSON.parse(res)); // note the typo
}); // no `.catch` or `.then`

Someone made off with the typo. When this is put back together I'd suggest updating to something like:

// note the typo (`pasre`)
@mscdex mscdex added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Mar 10, 2016
@Fishrock123
Copy link
Member

cc @jasnell

@MylesBorins
Copy link
Member

@jmm there should be a typo there that got fixed in a mass typo culling.

This could a a great little doc fix to send if you want to make a PR

@Trott Trott added the good first issue Issues that are suitable for first-time contributors. label Mar 11, 2016
@jmm
Copy link
Contributor Author

jmm commented Mar 11, 2016

@thealphanerd That's my point exactly 😃 It was a head scratcher at first.

I'm on strike from any doc PRs pending #3888 😸

@MylesBorins
Copy link
Member

I’ve commented in the other thread.. hopefully the strike can be brought to an end

I have a similar thing going on with buying synthesizers until I finish this x0xb0x kit I bought almost two years ago…

@jmm
Copy link
Contributor Author

jmm commented Mar 14, 2016

@thealphanerd Thanks. Ha...I guess I can't interest you in a Juno-60 that needs a good home then?

@MylesBorins
Copy link
Member

I'm listening

evanlucas pushed a commit that referenced this issue Mar 14, 2016
Reintroduces an intentional typo in a process doc example.

Fixes: #5644
PR-URL: #5654
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
rvagg pushed a commit that referenced this issue Mar 16, 2016
Reintroduces an intentional typo in a process doc example.

Fixes: #5644
PR-URL: #5654
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this issue Mar 17, 2016
Reintroduces an intentional typo in a process doc example.

Fixes: #5644
PR-URL: #5654
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this issue Mar 21, 2016
Reintroduces an intentional typo in a process doc example.

Fixes: #5644
PR-URL: #5654
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this issue Mar 21, 2016
Reintroduces an intentional typo in a process doc example.

Fixes: #5644
PR-URL: #5654
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@jmm
Copy link
Contributor Author

jmm commented Mar 26, 2016

@thealphanerd Well, I've done all the fiddling I'm going to do with this and I'm ready to let it go to greener pastures, just haven't had time to deal with it. Not a great photo, but it gives the gist 😃:

juno-60

So I don't spam people who aren't interested in this, want to email me at if you're really interested? (And no sweat if you're not. It was probably evil of me to introduce temptation under the circumstances anyway 😬)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. process Issues and PRs related to the process subsystem.
Projects
None yet
Development

No branches or pull requests

5 participants