Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: addon tests need more descriptive names than test.js #6651

Closed
gibfahn opened this issue May 9, 2016 · 2 comments
Closed

build: addon tests need more descriptive names than test.js #6651

gibfahn opened this issue May 9, 2016 · 2 comments
Labels
test Issues and PRs related to the tests.

Comments

@gibfahn
Copy link
Member

gibfahn commented May 9, 2016

  • Version: 6.1.0
  • Platform: all
  • Subsystem: addon tests

When looking at test failures, the only way to identify which test failed is by the name. Unfortunately all the tests in the addons folder are called test.js, which leads to unhelpful output (see below).

Currently it looks like there is only one test.js file in each folder in test/addons, so the simplest solution would be to name each test $ADDON_NAME-test.js. If that makes sense I can open a PR to do it.

Sample output from the community CI

ok 1048 test.js
  ---
  duration_ms: 0.171
  ...
ok 1049 test.js
  ---
  duration_ms: 1.216
  ...
ok 1050 test.js
  ---
  duration_ms: 0.138
  ...
ok 1051 test.js
  ---
  duration_ms: 0.138
  ...
ok 1052 test.js
  ---
  duration_ms: 0.137
  ...
ok 1053 test.js
  ---
  duration_ms: 0.170
  ...
ok 1054 test.js
  ---
  duration_ms: 0.138
  ...
ok 1055 test.js
  ---
  duration_ms: 0.141
  ...
ok 1056 test.js
  ---
  duration_ms: 0.137
  ...
ok 1057 test.js
  ---
  duration_ms: 0.263
  ...
ok 1058 test.js
  ---
  duration_ms: 0.329
  ...
@gibfahn
Copy link
Member Author

gibfahn commented May 9, 2016

Actually stringbytes-external-exceed-max has tests in the form test-$ADDON_NAME-specific-test-name, so it'd probably make more sense to do it that way.

@bnoordhuis
Copy link
Member

#6653 for a potential fix.

@bnoordhuis bnoordhuis added the test Issues and PRs related to the tests. label May 9, 2016
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue May 13, 2016
Print test name as (for example) "parallel/test-assert".  Tests that are
scraped from the addons documentation are all named test.js, making it
hard to decipher what test is running when only the filename is printed.

Fixes: nodejs#6651
PR-URL: nodejs#6653
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this issue May 17, 2016
Print test name as (for example) "parallel/test-assert".  Tests that are
scraped from the addons documentation are all named test.js, making it
hard to decipher what test is running when only the filename is printed.

Fixes: #6651
PR-URL: #6653
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue May 18, 2016
Print test name as (for example) "parallel/test-assert".  Tests that are
scraped from the addons documentation are all named test.js, making it
hard to decipher what test is running when only the filename is printed.

Fixes: #6651
PR-URL: #6653
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue May 18, 2016
Print test name as (for example) "parallel/test-assert".  Tests that are
scraped from the addons documentation are all named test.js, making it
hard to decipher what test is running when only the filename is printed.

Fixes: #6651
PR-URL: #6653
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

2 participants