Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs.open/fs.openSync in node v0.10.x can not propagate ENFILE errors #7199

Closed
rmg opened this issue Jun 7, 2016 · 2 comments
Closed

fs.open/fs.openSync in node v0.10.x can not propagate ENFILE errors #7199

rmg opened this issue Jun 7, 2016 · 2 comments
Labels
fs Issues and PRs related to the fs subsystem / file system. libuv Issues and PRs related to the libuv dependency or the uv binding.

Comments

@rmg
Copy link
Contributor

rmg commented Jun 7, 2016

  • Version: v0.10.x
  • Platform: posix
  • Subsystem: fs, deps

As described in libuv/libuv#899, libuv v0.10.x does not translate/propagate ENFILE errors, so node reports it as an UNKNOWN error code. Note that EMFILE occurs far more commonly, and this likely affects more tests (trying to trigger EMFILE/ENFILE to test errr handling) than actual applications.

I don't expect this issue to be fixed. This is mainly for people to find in search results.
@rmg rmg added libuv Issues and PRs related to the libuv dependency or the uv binding. v0.10 labels Jun 7, 2016
@rmg rmg mentioned this issue Jun 7, 2016
Closed
@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Jun 7, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Jun 8, 2016

Does this classify as something that really needs to be fixed in a maintenance release?

saghul added a commit to saghul/node that referenced this issue Jun 13, 2016
@saghul
deps: update libuv to 0.10.37
e9b4dfa 
Fixes: nodejs#7199
Refs: nodejs#2723
@saghul saghul mentioned this issue Jun 13, 2016
Closed
@jasnell
Copy link
Member

jasnell commented Oct 26, 2016

@nodejs/lts: Given that v0.10 is coming up to EOL and it is unlikely that we will be cutting a new v0.10 release, I recommend closing this.

@cjihrig cjihrig closed this as completed Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. libuv Issues and PRs related to the libuv dependency or the uv binding.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rmg @mscdex @jasnell @cjihrig