Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add data types to properties #9399

Closed
cjihrig opened this issue Nov 1, 2016 · 9 comments
Closed

doc: add data types to properties #9399

cjihrig opened this issue Nov 1, 2016 · 9 comments
Labels
doc Issues and PRs related to the documentations.

Comments

@cjihrig
Copy link
Contributor

cjihrig commented Nov 1, 2016

Some of the docs specify the type for properties, while others do not. A good first contribution would be to update the properties that are missing this information. As an example, look at https://nodejs.org/api/process.html#process_process_connected vs. https://nodejs.org/api/child_process.html#child_process_child_connected. These two things represent the same concept, but the one in the child_process docs have the data type.
@cjihrig cjihrig added good first issue Issues that are suitable for first-time contributors. docs-requested labels Nov 1, 2016
@JungMinu JungMinu self-assigned this Nov 2, 2016
@tanujasawant
Copy link
Contributor

@JungMinu Are you still planning on working on this issue? I am an Outreachy applicant and a newbie to Open Source. I have been visiting this issue with utmost excitement to see its outcome. Please comment if you're no longer interested.
Thanks!

@Trott
Copy link
Member

Trott commented Nov 3, 2016

I would request that people who already have contributions in the project please refrain from reserving new good first contribution issues. It makes the label considerably less useful for people looking for their actual first contribution.

(It's a bit different for a good first contribution issue that has been open for a while. If a good first contribution issue has been open for a few weeks, it's probably appropriate to remove the good first contribution label and submit a PR. But that's not the case here.)

@tanujasawant
Copy link
Contributor

@Trott Forgive me, I was unaware of the fact that people might still be looking for first contributions. I'll look for other issues. Thanks!

@JungMinu JungMinu removed their assignment Nov 4, 2016
@JungMinu
Copy link
Member

JungMinu commented Nov 4, 2016

@Trott Sorry, it was a mistake. I've just removed self-assignment

@imatveev imatveev mentioned this issue Nov 7, 2016
Closed
2 tasks
@imatveev
Copy link
Contributor

imatveev commented Nov 7, 2016 •
edited

Added most of values in pull-request

@imatveev imatveev mentioned this issue Nov 8, 2016
Closed
2 tasks
@imatveev
Copy link
Contributor

imatveev commented Nov 9, 2016

Yet another pull-request

@imatveev imatveev mentioned this issue Nov 16, 2016
Closed
2 tasks
@imatveev
Copy link
Contributor

Yet another pull-request

@sam-github sam-github added doc Issues and PRs related to the documentations. and removed doc Issues and PRs related to the documentations. docs-requested labels Dec 1, 2016
@targos
Copy link
Member

targos commented Jan 8, 2017

Are there still missing types?

@ameliavoncat ameliavoncat mentioned this issue Feb 25, 2017
Closed
2 tasks
@ameliavoncat ameliavoncat mentioned this issue Feb 25, 2017
Closed
2 tasks
ameliavoncat added a commit to ameliavoncat/node that referenced this issue Feb 25, 2017
@ameliavoncat
doc: argument types for console methods
dbc241c 
Refs: nodejs#9399
ameliavoncat added a commit to ameliavoncat/node that referenced this issue Feb 25, 2017
@ameliavoncat
doc: argument types for assert methods
d1b6dd3 
Refs: nodejs#9399
@ameliavoncat ameliavoncat mentioned this issue Mar 11, 2017
Closed
2 tasks
ameliavoncat added a commit to ameliavoncat/node that referenced this issue Mar 11, 2017
@ameliavoncat
doc: missing argument types for events methods
f581702 
Refs: nodejs#9399
italoacasas pushed a commit to italoacasas/node that referenced this issue Mar 13, 2017
@ameliavoncat @italoacasas
doc: argument types for https methods
9c3cf13 
Ref: nodejs#9399
PR-URL: nodejs#11681
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this issue Mar 14, 2017
@ameliavoncat @italoacasas
doc: http cleanup and missing argument types
a20aa0e 
Ref: nodejs#9399
PR-URL: nodejs#11681
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
ameliavoncat added a commit to ameliavoncat/node that referenced this issue Mar 14, 2017
@ameliavoncat
doc: argument types for crypto methods
92d6668 
Refs: nodejs#9399
jasnell pushed a commit that referenced this issue Mar 15, 2017
@ameliavoncat @jasnell
doc: missing argument types for events methods
38ba0c2 
Refs: #9399
PR-URL: #11802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
jasnell pushed a commit that referenced this issue Mar 15, 2017
@ameliavoncat @jasnell
doc: argument types for crypto methods
73e2d0b 
Refs: #9399
PR-URL: #11799
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
jasnell pushed a commit that referenced this issue Mar 15, 2017
@ameliavoncat @jasnell
doc: argument types for dns methods
1faf136 
Refs: #9399
PR-URL: #11764
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this issue Mar 20, 2017
@ameliavoncat @italoacasas
doc: missing argument types for events methods
75fcf53 
Refs: nodejs#9399
PR-URL: nodejs#11802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
italoacasas pushed a commit to italoacasas/node that referenced this issue Mar 20, 2017
@ameliavoncat @italoacasas
doc: argument types for dns methods
78ca15d 
Refs: nodejs#9399
PR-URL: nodejs#11764
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jungx098 pushed a commit to jungx098/node that referenced this issue Mar 21, 2017
@ameliavoncat @jungx098
doc: argument types for https methods
29bd64d 
Ref: nodejs#9399
PR-URL: nodejs#11681
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
jungx098 pushed a commit to jungx098/node that referenced this issue Mar 21, 2017
@ameliavoncat @jungx098
doc: http cleanup and missing argument types
91ce8fc 
Ref: nodejs#9399
PR-URL: nodejs#11681
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
jungx098 pushed a commit to jungx098/node that referenced this issue Mar 21, 2017
@ameliavoncat @jungx098
doc: missing argument types for events methods
3b7c9e0 
Refs: nodejs#9399
PR-URL: nodejs#11802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
jungx098 pushed a commit to jungx098/node that referenced this issue Mar 21, 2017
@ameliavoncat @jungx098
doc: argument types for crypto methods
941009a 
Refs: nodejs#9399
PR-URL: nodejs#11799
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
jungx098 pushed a commit to jungx098/node that referenced this issue Mar 21, 2017
@ameliavoncat @jungx098
doc: argument types for dns methods
97cf298 
Refs: nodejs#9399
PR-URL: nodejs#11764
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn pushed a commit that referenced this issue Jun 17, 2017
@ameliavoncat @gibfahn
doc: argument types for https methods
beb1644 
Ref: #9399
PR-URL: #11681
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
gibfahn pushed a commit that referenced this issue Jun 20, 2017
@ameliavoncat @gibfahn
doc: argument types for https methods
b956e32 
Ref: #9399
PR-URL: #11681
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins pushed a commit that referenced this issue Jul 11, 2017
@ameliavoncat @MylesBorins
doc: argument types for https methods
7ba172f 
Ref: #9399
PR-URL: #11681
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@Trott
Copy link
Member

Trott commented Jul 15, 2017

This issue has been inactive for sufficiently long that it seems like perhaps it should be closed. Feel free to re-open (or leave a comment requesting that it be re-opened) if you disagree. I'm just tidying up and not acting on a super-strong opinion or anything like that.

@Trott Trott closed this as completed Jul 15, 2017
@Trott Trott removed the good first issue Issues that are suitable for first-time contributors. label Jul 15, 2017
@aliscco aliscco mentioned this issue Jun 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@sam-github @Trott @targos @cjihrig @JungMinu @tanujasawant @imatveev