Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we document the AtExit function for addons? #999

Closed
JCMais opened this issue Feb 28, 2015 · 2 comments
Closed

Can we document the AtExit function for addons? #999

JCMais opened this issue Feb 28, 2015 · 2 comments
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. doc Issues and PRs related to the documentations.

Comments

@JCMais
Copy link
Contributor

JCMais commented Feb 28, 2015

The function AtExit act as a module shutdown callback, and was added in this commit bnoordhuis/node@1c20cac, but was never documented (why?).

I'm pretty sure many addon developers wanted something like that, but probably never used that function because it is not documented anywhere.

There is a pull request here with documentation, but it was not merged into node for unknown reasons.
@brendanashworth
Copy link
Contributor

for reference, e4a8d26 is the io.js equivalent commit. also, if you'd like to use the same change as that noted pull request, you could take the commits within and resubmit them here - typically pull requests provide better discussion over whether or not something should be added than just an issue.

@JCMais JCMais mentioned this issue Mar 1, 2015
Closed
@mscdex mscdex added c++ Issues and PRs that require attention from people who are familiar with C++. doc Issues and PRs related to the documentations. labels Mar 9, 2015
bnoordhuis pushed a commit that referenced this issue May 26, 2015
@OpenSourceSteve @bnoordhuis
doc: add documentation for AtExit hook
98649fd 
Fixes: #999
PR-URL: #1014
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@bnoordhuis
Copy link
Member

Fixed by 98649fd.

andrewdeandrade pushed a commit to andrewdeandrade/node that referenced this issue Jun 3, 2015
@OpenSourceSteve @andrewdeandrade
doc: add documentation for AtExit hook
8db847f 
Fixes: nodejs/node#999
PR-URL: nodejs/node#1014
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@leonardoadame leonardoadame mentioned this issue Dec 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mscdex @bnoordhuis @JCMais @brendanashworth