Allow to explicitly define a build as (not) cross-compiled #10287
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
addaleax
approved these changes
Dec 15, 2016
There was a problem hiding this comment.
This fixes issue #10271
Could you add a Fixes: https://github.com/nodejs/node/issues/10271 line at the end of the commit message? :)
Done, thank you for the advice :-) |
jasnell
approved these changes
Dec 23, 2016
|
New CI, just in case: https://ci.nodejs.org/job/node-test-pull-request/5555/ |
bnoordhuis
approved these changes
Dec 23, 2016
|
Commit log suggestion: |
Adds --cross-compiling and --no-cross-compiling flags Fixes: nodejs#10271
Done, thanks for the suggestion :-) |
|
Landed in 8e60e0f |
|
Thank you :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Build and compilation
Description of change
This fixes issue #10271, allowing to explicitly set that we are doing a cross-compilation (or not, if we desire so) instead of only rely on heuristics. This is useful when you are compiling to the same target CPU of your host system by using a toolchain that uses a different C lib (like musl from glib), since
mkpeepholegets compiled with the cross-toolchain and later can't be executed. This way we can force it to use the host toolchain instead. By default it still use the heuristics.I have checked that it correctly set the GYP variables correctly and the compiled Node.js works as expected.