Allow to explicitly define a build as (not) cross-compiled #10287

Closed
wants to merge 1 commit into
from

Projects

None yet

7 participants

@piranna
Contributor
piranna commented Dec 15, 2016
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Build and compilation

Description of change

This fixes issue #10271, allowing to explicitly set that we are doing a cross-compilation (or not, if we desire so) instead of only rely on heuristics. This is useful when you are compiling to the same target CPU of your host system by using a toolchain that uses a different C lib (like musl from glib), since mkpeephole gets compiled with the cross-toolchain and later can't be executed. This way we can force it to use the host toolchain instead. By default it still use the heuristics.

I have checked that it correctly set the GYP variables correctly and the compiled Node.js works as expected.

@addaleax

This fixes issue #10271

Could you add a Fixes: https://github.com/nodejs/node/issues/10271 line at the end of the commit message? :)

CI: https://ci.nodejs.org/job/node-test-commit/6665/

@piranna
Contributor
piranna commented Dec 15, 2016

Could you add a Fixes: #10271 line at the end of the commit message? :)

Done, thank you for the advice :-)

@jasnell jasnell self-assigned this Dec 23, 2016
@bnoordhuis

LGTM but please format the commit log according to the style guide from CONTRIBUTING.md.

@gibfahn
Member
gibfahn commented Dec 23, 2016

Commit log suggestion:

build: add (not) cross-compiled configure flags

Adds --cross-compiling and --no-cross-compiling flags

Fixes: https://github.com/nodejs/node/issues/10271
@piranna piranna build: add (not) cross-compiled configure flags
Adds --cross-compiling and --no-cross-compiling flags

Fixes: nodejs#10271
b09d14e
@piranna
Contributor
piranna commented Dec 26, 2016

Commit log suggestion:

build: add (not) cross-compiled configure flags

Adds --cross-compiling and --no-cross-compiling flags

Fixes: #10271

Done, thanks for the suggestion :-)

@jasnell jasnell added a commit that referenced this pull request Dec 27, 2016
@piranna @jasnell piranna + jasnell build: add (not) cross-compiled configure flags
Adds --cross-compiling and --no-cross-compiling flags

Fixes: #10271
PR-URL: #10287
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
8e60e0f
@jasnell
Member
jasnell commented Dec 27, 2016

Landed in 8e60e0f

@jasnell jasnell closed this Dec 27, 2016
@piranna
Contributor
piranna commented Dec 27, 2016

Thank you :-)

@joyeecheung joyeecheung added a commit to joyeecheung/node that referenced this pull request Jan 2, 2017
@piranna @joyeecheung piranna + joyeecheung build: add (not) cross-compiled configure flags
Adds --cross-compiling and --no-cross-compiling flags

Fixes: nodejs#10271
PR-URL: nodejs#10287
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
134c426
@evanlucas evanlucas added a commit that referenced this pull request Jan 3, 2017
@piranna @evanlucas piranna + evanlucas build: add (not) cross-compiled configure flags
Adds --cross-compiling and --no-cross-compiling flags

Fixes: #10271
PR-URL: #10287
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
ec28466
@evanlucas evanlucas referenced this pull request Jan 3, 2017
Merged

v7.4.0 release proposal #10589

@evanlucas evanlucas added a commit that referenced this pull request Jan 3, 2017
@piranna @evanlucas piranna + evanlucas build: add (not) cross-compiled configure flags
Adds --cross-compiling and --no-cross-compiling flags

Fixes: #10271
PR-URL: #10287
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
be4e2bc
@evanlucas evanlucas added a commit that referenced this pull request Jan 4, 2017
@piranna @evanlucas piranna + evanlucas build: add (not) cross-compiled configure flags
Adds --cross-compiling and --no-cross-compiling flags

Fixes: #10271
PR-URL: #10287
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
cff57be
@MylesBorins MylesBorins added a commit that referenced this pull request Jan 23, 2017
@piranna @MylesBorins piranna + MylesBorins build: add (not) cross-compiled configure flags
Adds --cross-compiling and --no-cross-compiling flags

Fixes: #10271
PR-URL: #10287
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
b7279bc
@MylesBorins MylesBorins added a commit that referenced this pull request Jan 23, 2017
@piranna @MylesBorins piranna + MylesBorins build: add (not) cross-compiled configure flags
Adds --cross-compiling and --no-cross-compiling flags

Fixes: #10271
PR-URL: #10287
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
a289b05
@MylesBorins MylesBorins added a commit that referenced this pull request Jan 23, 2017
@piranna @MylesBorins piranna + MylesBorins build: add (not) cross-compiled configure flags
Adds --cross-compiling and --no-cross-compiling flags

Fixes: #10271
PR-URL: #10287
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
418d5ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment