deps: cherry-pick 081fce3 from V8 upstream #10342
Closed
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original commit message: ThreadTicks::Now support for Solaris BUG=v8:5739 Review-Url: https://codereview.chromium.org/2576903004 Cr-Commit-Position: refs/heads/master@{#41771}
nodejs-github-bot
added
the
v8 engine
|
@matthewloring should this be backported to v4 or v6? |
|
@thealphanerd Nope, this is only needed to support trace event which has not yet landed on master. |
3 tasks
|
LGTM |
|
@geek Thank you for contributing the fix! |
targos
approved these changes
Dec 19, 2016
|
Everything looks green on Jenkins. I'm not sure why the test/arm run reported a failure to the PR despite passing. Maybe @nodejs/build can have a look. |
|
ARM seems to have a problem reporting to the top multijob as of recently. |
|
Errr.... hmmm.. Maybe it's a bot problem? It seems like it's propagating in Jenkins but the bot is forwarding it incorrectly. @nodejs/github-bot |
ofrobots
approved these changes
Dec 19, 2016
|
Landed in: a308a2f |
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Dec 20, 2016
Original commit message: ThreadTicks::Now support for Solaris BUG=v8:5739 Review-Url: https://codereview.chromium.org/2576903004 Cr-Commit-Position: refs/heads/master@{nodejs#41771} PR-URL: nodejs#10342 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Merged
cjihrig
pushed a commit
that referenced
this pull request
Dec 20, 2016
Original commit message: ThreadTicks::Now support for Solaris BUG=v8:5739 Review-Url: https://codereview.chromium.org/2576903004 Cr-Commit-Position: refs/heads/master@{#41771} PR-URL: #10342 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit message:
ThreadTicks::Now support for Solaris
BUG=v8:5739
Review-Url: https://codereview.chromium.org/2576903004
Cr-Commit-Position: refs/heads/master@{#41771}