Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add Michaël Zasso to the CTC #10381

Merged
merged 1 commit into from
Dec 21, 2016
Merged

doc: add Michaël Zasso to the CTC #10381

merged 1 commit into from
Dec 21, 2016

Conversation

targos
Copy link
Member

@targos targos commented Dec 21, 2016

Approved by the CTC at #9420
Reviewers are CTC members who voted for this.

Reviewed-By: Rich Trott rtrott@gmail.com
Reviewed-By: Evan Lucas evanlucas@me.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Сковорода Никита Андреевич chalkerx@gmail.com
Reviewed-By: Ali Ijaz Sheikh ofrobots@google.com
Reviewed-By: Julien Gilli jgilli@nodejs.org
Reviewed-By: Myles Borins myles.borins@gmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: Fedor Indutny fedor.indutny@gmail.com
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl
Reviewed-By: Sakthipriyan Vairamani thechargingvolcano@gmail.com

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. lts-watch-v6.x labels Dec 21, 2016
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome on board!

Copy link
Contributor

@thefourtheye thefourtheye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the club :-)

@rvagg
Copy link
Member

rvagg commented Dec 21, 2016

lgtm, please also add yourself to ctc @ https://github.com/nodejs/email/blob/master/iojs.org/aliases.json

Approved by the CTC at nodejs#9420
Reviewers are CTC members who voted for this.

Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@brad-decker
Copy link
Contributor

Congrats!

@targos
Copy link
Member Author

targos commented Dec 21, 2016

Landed in 9e4a899. Thanks again!

@targos targos closed this Dec 21, 2016
@targos targos deleted the ctc branch December 21, 2016 17:11
@targos targos merged commit 9e4a899 into nodejs:master Dec 21, 2016
@targos
Copy link
Member Author

targos commented Dec 21, 2016

I requested to join the @nodejs/ctc team. Any other administrative thing to do?

@Trott
Copy link
Member

Trott commented Dec 21, 2016

I requested to join the @nodejs/ctc team. Any other administrative thing to do?

I think @rvagg might have a checklist of things for when someone is added to the CTC.

MylesBorins referenced this pull request Jan 23, 2017
Approved by the CTC at #9420
Reviewers are CTC members who voted for this.

Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants