New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: clean up usage of threw #10534

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
@JacksonTian
Contributor

JacksonTian commented Dec 30, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

bootstrap_node, module, timers

Show outdated Hide outdated lib/timers.js
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Dec 30, 2016

Member

hmm... @Fishrock123 are you familiar with why threw was in here in the first place? And why this was being handled in a finally block rather than in a catch?

Member

jasnell commented Dec 30, 2016

hmm... @Fishrock123 are you familiar with why threw was in here in the first place? And why this was being handled in a finally block rather than in a catch?

@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 Dec 31, 2016

Member

I think this is a performance optimization of some sort. This should be profiled. (e.g. --prof, not just microbenchmarks.)

Member

Fishrock123 commented Dec 31, 2016

I think this is a performance optimization of some sort. This should be profiled. (e.g. --prof, not just microbenchmarks.)

@JacksonTian

This comment has been minimized.

Show comment
Hide comment
@JacksonTian

JacksonTian Jan 2, 2017

Contributor

I hold the change of module.js, there are test cases check the append excpection message.

Contributor

JacksonTian commented Jan 2, 2017

I hold the change of module.js, there are test cases check the append excpection message.

@Fishrock123

(Requesting the aforementioned profiling)

@JacksonTian

This comment has been minimized.

Show comment
Hide comment
@JacksonTian

JacksonTian Jan 3, 2017

Contributor

@Fishrock123 How to profiling it? Hope to get some suggestions.

Contributor

JacksonTian commented Jan 3, 2017

@Fishrock123 How to profiling it? Hope to get some suggestions.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Mar 24, 2017

Member

ping @Fishrock123 ...

any updates on this one?

Member

jasnell commented Mar 24, 2017

ping @Fishrock123 ...

any updates on this one?

@jasnell jasnell added the stalled label Mar 24, 2017

@BridgeAR

This comment has been minimized.

Show comment
Hide comment
@BridgeAR

BridgeAR Aug 26, 2017

Member

@JacksonTian this needs a rebase. And can you please comment when you did? There is no notification otherwise and I see that you rebased the last time you were asked to.

Member

BridgeAR commented Aug 26, 2017

@JacksonTian this needs a rebase. And can you please comment when you did? There is no notification otherwise and I see that you rebased the last time you were asked to.

@JacksonTian

This comment has been minimized.

Show comment
Hide comment
@JacksonTian

JacksonTian Aug 26, 2017

Contributor

rebased.

Contributor

JacksonTian commented Aug 26, 2017

rebased.

@BridgeAR

LGTM if CI is green

@BridgeAR

This comment has been minimized.

Show comment
Hide comment
@BridgeAR

BridgeAR Aug 26, 2017

Member

I benchmarked this recently and could not find any difference performance wise.
@Fishrock123 I am going to dismiss your review because of that. Please have another look.

Member

BridgeAR commented Aug 26, 2017

I benchmarked this recently and could not find any difference performance wise.
@Fishrock123 I am going to dismiss your review because of that. Please have another look.

No reaction and the performance should not be affected

BridgeAR added a commit to BridgeAR/node that referenced this pull request Aug 29, 2017

lib: clean up usage of threw
PR-URL: nodejs#10534
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR

This comment has been minimized.

Show comment
Hide comment
@BridgeAR

BridgeAR Aug 29, 2017

Member

Landed in d56a82d

Member

BridgeAR commented Aug 29, 2017

Landed in d56a82d

@BridgeAR BridgeAR closed this Aug 29, 2017

@BridgeAR

This comment has been minimized.

Show comment
Hide comment
@BridgeAR

BridgeAR Aug 29, 2017

Member

The test actually fails and I just force pushed to remove the commit again.

Member

BridgeAR commented Aug 29, 2017

The test actually fails and I just force pushed to remove the commit again.

@BridgeAR BridgeAR reopened this Aug 29, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 29, 2017

Member

It doesn't look like there were any CI runs for this so good call backing it out. Bonus points for it being within the 10 minute window ;-)

Member

jasnell commented Aug 29, 2017

It doesn't look like there were any CI runs for this so good call backing it out. Bonus points for it being within the 10 minute window ;-)

@BridgeAR

This comment has been minimized.

Show comment
Hide comment
@BridgeAR

BridgeAR Aug 29, 2017

Member

I knew why I said

LGTM if CI is green

I somewhat had a bad feeling about it but I forgot to run it right before I pushed.

Member

BridgeAR commented Aug 29, 2017

I knew why I said

LGTM if CI is green

I somewhat had a bad feeling about it but I forgot to run it right before I pushed.

@JacksonTian

This comment has been minimized.

Show comment
Hide comment
@JacksonTian

JacksonTian Aug 30, 2017

Contributor

Oh. Let's run CI again?

Contributor

JacksonTian commented Aug 30, 2017

Oh. Let's run CI again?

lib: clean up usage of threw
Use try/catch to instead of threw.
@JacksonTian

This comment has been minimized.

Show comment
Hide comment
@JacksonTian

JacksonTian Aug 30, 2017

Contributor

Sorry, My mistake. After rebased with master, the test message no more need update. Now I removed it.

Contributor

JacksonTian commented Aug 30, 2017

Sorry, My mistake. After rebased with master, the test message no more need update. Now I removed it.

@aqrln

This comment has been minimized.

Show comment
Hide comment
@BridgeAR

This comment has been minimized.

Show comment
Hide comment
@BridgeAR

BridgeAR Aug 30, 2017

Member

Landed in 67d792a

Member

BridgeAR commented Aug 30, 2017

Landed in 67d792a

@BridgeAR BridgeAR closed this Aug 30, 2017

BridgeAR added a commit that referenced this pull request Aug 30, 2017

lib: clean up usage of threw
Use try/catch to instead of threw.

PR-URL: #10534
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

cjihrig added a commit to cjihrig/node-1 that referenced this pull request Aug 31, 2017

lib: clean up usage of threw
Use try/catch to instead of threw.

PR-URL: nodejs#10534
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@JacksonTian JacksonTian deleted the JacksonTian:threw branch Sep 2, 2017

addaleax added a commit to addaleax/ayo that referenced this pull request Sep 5, 2017

lib: clean up usage of threw
Use try/catch to instead of threw.

PR-URL: nodejs/node#10534
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 10, 2017

lib: clean up usage of threw
Use try/catch to instead of threw.

PR-URL: #10534
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@MylesBorins MylesBorins referenced this pull request Sep 10, 2017

Merged

v8.5.0 proposal #15308

MylesBorins added a commit that referenced this pull request Sep 12, 2017

lib: clean up usage of threw
Use try/catch to instead of threw.

PR-URL: #10534
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 20, 2017

lib: clean up usage of threw
Use try/catch to instead of threw.

PR-URL: #10534
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Sep 20, 2017

Member

backported to v6.x

Let me know if it should be backed out

Member

MylesBorins commented Sep 20, 2017

backported to v6.x

Let me know if it should be backed out

@MylesBorins MylesBorins referenced this pull request Sep 20, 2017

Merged

v6.11.4 proposal #15506

MylesBorins added a commit that referenced this pull request Sep 26, 2017

lib: clean up usage of threw
Use try/catch to instead of threw.

PR-URL: #10534
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment