Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: update fs module #10591

Closed
wants to merge 6 commits into from
Closed

fs: update fs module #10591

wants to merge 6 commits into from

Conversation

elreeda
Copy link

@elreeda elreeda commented Jan 3, 2017 •
edited

the goal of this PR is to use local variable by replacing var with const and let.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

fs

@elreeda
fs: update fs module
662542d 
- replace var with const and let
@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. dont-land-on-v7.x labels Jan 3, 2017
@mscdex
Copy link
Contributor

mscdex commented Jan 3, 2017 •
edited

I'm not sure we're converting core modules (wholesale) yet, since there may still be some performance concerns at the very least ...

thefourtheye
thefourtheye reviewed Jan 3, 2017
View reviewed changes
lib/fs.js
return m;
if (typeof m === 'string')
} else if (typeof m === 'string') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These may not be necessary, right?

benjamingr
benjamingr requested changes Jan 3, 2017
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm -1 on this PR. I think it will degrade blame without adding much improvement and it also requires a lot of work to properly review.

@elreeda
Copy link
Author

elreeda commented Jan 9, 2017

sorry for the misunderstand, I thought it would a cool idea to make these change in the core modules (fs) anyway here is another commit where I change var to const and equal to strictEqual only in tests.

cc: @Trott

@Trott
Copy link
Member

Trott commented Jan 10, 2017

Lots of conflicts. Can you rebase?

@mscdex
Copy link
Contributor

mscdex commented Jan 10, 2017

The commit that makes changes to fs needs to be removed yet FWIW.

@mscdex mscdex added the wip Issues and PRs that are still a work in progress. label Jan 12, 2017
@elreeda elreeda closed this Feb 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thefourtheye thefourtheye thefourtheye left review comments

@benjamingr benjamingr benjamingr requested changes

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. wip Issues and PRs that are still a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@elreeda @mscdex @Trott @thefourtheye @benjamingr @targos @nodejs-github-bot