Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] meta: update copyright statements #10599

Closed
wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jan 3, 2017

This is a WIP follow-on to #10155
It updates the copyright notices in the lib/src files. This is WIP and must not be landed until @nodejs/tsc signoff and Node.js Foundation Legal Committee review.

/cc @mikeal

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

lib, src

@jasnell jasnell added the wip Issues and PRs that are still a work in progress. label Jan 3, 2017
@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. dont-land-on-v7.x labels Jan 3, 2017
@jasnell
Copy link
Member Author

jasnell commented Jan 3, 2017

Note: this includes the commit from #10155 ... the expectation is that #10155 would land first

@jasnell jasnell added ctc-agenda semver-major PRs that contain breaking changes and should be released in the next major version. labels Jan 4, 2017
@trevnorris
Copy link
Contributor

@mikeal Can we get the legal team to review and sign-off on the new header ASAP? I don't want to be stuck with this massive header for the next 6 months waiting for the legal committee to review this. Especially since they're known to take their sweet time.

@bnoordhuis I've been told you're actually going to be speaking w/ the legal team directly. If this is correct, can you also bring up the need to immediately review the new header?

@trevnorris
Copy link
Contributor

@rvagg I was told you're the only other one that has access to the legal team. Can you also put pressure on the legal team, or let me know how I can communicate w/ them directly (because, that would make more sense), that they sign-off on the new header?

@trevnorris trevnorris mentioned this pull request Jan 4, 2017
2 tasks
@jasnell
Copy link
Member Author

jasnell commented Jan 4, 2017

I have sent a note to @mikeal and @rvagg asking them to formally request legal committee review. Hopefully we'll get a timely review of the changes.

@ChALkeR
Copy link
Member

ChALkeR commented Jan 10, 2017

Does «All rights reserved» mean anything nowdays in any country?

Wikipedia says:

no longer has any legal effect in any jurisdiction

@jasnell
Copy link
Member Author

jasnell commented Jan 10, 2017

Largely just an artifact of history, I believe. I don't have a problem removing it

@ChALkeR
Copy link
Member

ChALkeR commented Jan 18, 2017

@jasnell I have a highly subjective opinion that it makes it a bit more aggresive for no good reason, e.g. I wouldn't be very surprised if someone who doesn't know what exactly that means would be scared off by it instead of reusing code and/or contributing.

Just ignore me if no one else thinks that way, though =). This concern is both subjective and very minor.

@jasnell
Copy link
Member Author

jasnell commented Jan 18, 2017

Removing the "All rights reserved" I think would be fine. I can update the proposal accordingly.

@Fishrock123
Copy link
Member

I'm not too sure about All rights reserved. either. The rights aren't reserved, it is MIT licensed...?

@mikeal
Copy link
Contributor

mikeal commented Feb 3, 2017

From legal committee, preferred language:

Copyright Node.js contributors. All rights reserved.
SPDX-License-Identifier: MIT

The legal committee consensus is that this should not be landed yet but that the simplified text with the SPDX reference should be used.

The legal committee also wanted to note that the "All rights reserved" should remain because it is used in other vendored notice blocks and it might cause confusion if it were in some files but not others.

@jasnell
Copy link
Member Author

jasnell commented Feb 3, 2017

I will get the PRs updated by Tuesday or Wednesday of next week.
It should also be noted that the legal committee requested that additional documentation be added to the contributor guide discussing:

  • The requirement for the copyright header to appear at the top of every /lib/*.js, /src/*.cc, and /src/*.h file
  • The requirement for appropriate attribution and maintenance of attribution in vendored-in files

I will also be introducing lint rules to ensure that the appropriate copyright statements appear at the top of each file

@jasnell
Copy link
Member Author

jasnell commented Feb 6, 2017

This PR has been updated to only include the new proposed license header and an eslint rule to enforce it's use.

@bnoordhuis @jbergstroem ... we need a similar rule for cpplint to check the src/.h and src/.cc files. I'm not that familiar with cpplint so perhaps either of you could help?

@bnoordhuis
Copy link
Member

Shouldn't be too hard. Remove -legal/copyright from _DEFAULT_FILTERS and make CheckForCopyright() check for the expected license.

@jasnell
Copy link
Member Author

jasnell commented Feb 6, 2017

ok, so just make the change directly to the cpplint.py script. That's what I suspected but needed to be sure. Thank you!

jasnell added a commit to jasnell/node that referenced this pull request Mar 9, 2017
A prior io.js era commit inappropriately removed the
original copyright statements from the source. This
restores those in any files still remaining from that
edit.

Ref: nodejs/TSC#174
Ref: nodejs#10599
jasnell added a commit that referenced this pull request Mar 10, 2017
A prior io.js era commit inappropriately removed the
original copyright statements from the source. This
restores those in any files still remaining from that
edit.

Ref: nodejs/TSC#174
Ref: #10599
PR-URL: #10155

Note: This PR was required, reviewed-by and approved
by the Node.js Foundation Legal Committee and the TSC.
There is no `Approved-By:` meta data.
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
A prior io.js era commit inappropriately removed the
original copyright statements from the source. This
restores those in any files still remaining from that
edit.

Ref: nodejs/TSC#174
Ref: nodejs#10599
PR-URL: nodejs#10155

Note: This PR was required, reviewed-by and approved
by the Node.js Foundation Legal Committee and the TSC.
There is no `Approved-By:` meta data.
@jasnell
Copy link
Member Author

jasnell commented Sep 12, 2017

Closing this due to any lack of progress.

@jasnell jasnell closed this Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. semver-major PRs that contain breaking changes and should be released in the next major version. wip Issues and PRs that are still a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants