test,net: add tests for server.connections #10762
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were no tests confirming situations where server.connections should return `null`. Add a test for that situation. Expand existing server.connection test slightly to check value. Refactor (mostly spacing) code for server.connections setter.
Trott
added
net
nodejs-github-bot
added
net
jasnell
reviewed
Jan 12, 2017
| assert.strictEqual(Object.keys(server).indexOf('connections'), -1); | ||
|
|
||
| assert.strictEqual(server.connections, 0); |
There was a problem hiding this comment.
You might also consider adding a check for the deprecation warning... e.g.
common.expectWarning('DeprecationWarning',
'Server.connections property is deprecated.');
jasnell
approved these changes
Jan 12, 2017
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 15, 2017
There were no tests confirming situations where server.connections should return `null`. Add a test for that situation. Expand existing server.connection test slightly to check value. Refactor (mostly spacing) code for server.connections setter. PR-URL: nodejs#10762 Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 97f001a |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
There were no tests confirming situations where server.connections should return `null`. Add a test for that situation. Expand existing server.connection test slightly to check value. Refactor (mostly spacing) code for server.connections setter. PR-URL: nodejs#10762 Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jan 19, 2017
targos
pushed a commit
that referenced
this pull request
Jan 28, 2017
There were no tests confirming situations where server.connections should return `null`. Add a test for that situation. Expand existing server.connection test slightly to check value. Refactor (mostly spacing) code for server.connections setter. PR-URL: #10762 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
There were no tests confirming situations where server.connections should return `null`. Add a test for that situation. Expand existing server.connection test slightly to check value. Refactor (mostly spacing) code for server.connections setter. PR-URL: nodejs#10762 Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
There were no tests confirming situations where server.connections should return `null`. Add a test for that situation. Expand existing server.connection test slightly to check value. Refactor (mostly spacing) code for server.connections setter. PR-URL: nodejs#10762 Reviewed-By: James M Snell <jasnell@gmail.com>
|
A backport PR would be required in order for this to land in v6 or v4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were no tests confirming situations where server.connections
should return
null. Add a test for that situation.Expand existing server.connection test slightly to check value.
Refactor (mostly spacing) code for server.connections setter.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test net