test: fix test.py command line options processing #11153

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
7 participants
@misterdjules

#11086 had introduced a regression
that broke command line options processing for tools/test.py.

Basically, it made tools/test.py discard the command line argument that
would be passed after --abort-on-timeout. For instance, when running:

$ python tools/test.py --abort-on-timeout path/to/some-test

all tests would be run because the last command line argument
(/path/to/some-test) would be discarded.

This change fixes this regression.

Refs: #11086

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Julien Gilli
test: fix test.py command line options processing
#11086 had introduced a regression
that broke command line options processing for tools/test.py.

Basically, it made tools/test.py discard the command line argument that
would be passed after `--abort-on-timeout`. For instance, when running:

```
$ python tools/test.py --abort-on-timeout path/to/some-test
```

all tests would be run because the last command line argument
(`/path/to/some-test`) would be discarded.

This change fixes this regression.

Refs: #11086

@misterdjules misterdjules added the test label Feb 3, 2017

@misterdjules misterdjules referenced this pull request Feb 3, 2017

Closed

test: add --abort-on-timeout option to test.py #11086

2 of 2 tasks complete
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Feb 3, 2017

Member

good catch. LGTM

Member

jasnell commented Feb 3, 2017

good catch. LGTM

@cjihrig

cjihrig approved these changes Feb 3, 2017

@gibfahn

This comment has been minimized.

Show comment
Hide comment
Member

gibfahn commented Feb 3, 2017

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Feb 4, 2017

Member

This doesn’t need to wait 48 hours
CI: https://ci.nodejs.org/job/node-test-commit/7673/

Member

addaleax commented Feb 4, 2017

This doesn’t need to wait 48 hours
CI: https://ci.nodejs.org/job/node-test-commit/7673/

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Feb 4, 2017

Member

The OS X CI failure is infrastructure-related, and I don’t think CI can actually test this code beyond “it’s not breaking the world”.

Landed in 23cda7d

Member

addaleax commented Feb 4, 2017

The OS X CI failure is infrastructure-related, and I don’t think CI can actually test this code beyond “it’s not breaking the world”.

Landed in 23cda7d

@addaleax addaleax closed this Feb 4, 2017

addaleax added a commit that referenced this pull request Feb 4, 2017

test: fix test.py command line options processing
#11086 had introduced a regression
that broke command line options processing for tools/test.py.

Basically, it made tools/test.py discard the command line argument that
would be passed after `--abort-on-timeout`. For instance, when running:

```
$ python tools/test.py --abort-on-timeout path/to/some-test
```

all tests would be run because the last command line argument
(`/path/to/some-test`) would be discarded.

This change fixes this regression.

Refs: #11086
PR-URL: #11153
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 5, 2017

test: fix test.py command line options processing
nodejs#11086 had introduced a regression
that broke command line options processing for tools/test.py.

Basically, it made tools/test.py discard the command line argument that
would be passed after `--abort-on-timeout`. For instance, when running:

```
$ python tools/test.py --abort-on-timeout path/to/some-test
```

all tests would be run because the last command line argument
(`/path/to/some-test`) would be discarded.

This change fixes this regression.

Refs: nodejs#11086
PR-URL: nodejs#11153
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@misterdjules

This comment has been minimized.

Show comment
Hide comment
@misterdjules

misterdjules Feb 8, 2017

When back porting to v6.x and v4.x branches, make sure to back port #11086 first, as this PR depends on it.

When back porting to v6.x and v4.x branches, make sure to back port #11086 first, as this PR depends on it.

misterdjules pushed a commit to misterdjules/node-1 that referenced this pull request Feb 13, 2017

Julien Gilli
test: fix test.py command line options processing
nodejs#11086 had introduced a regression
that broke command line options processing for tools/test.py.

Basically, it made tools/test.py discard the command line argument that
would be passed after `--abort-on-timeout`. For instance, when running:

```
$ python tools/test.py --abort-on-timeout path/to/some-test
```

all tests would be run because the last command line argument
(`/path/to/some-test`) would be discarded.

This change fixes this regression.

Refs: nodejs#11086
PR-URL: nodejs#11153
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

test: fix test.py command line options processing
nodejs#11086 had introduced a regression
that broke command line options processing for tools/test.py.

Basically, it made tools/test.py discard the command line argument that
would be passed after `--abort-on-timeout`. For instance, when running:

```
$ python tools/test.py --abort-on-timeout path/to/some-test
```

all tests would be run because the last command line argument
(`/path/to/some-test`) would be discarded.

This change fixes this regression.

Refs: nodejs#11086
PR-URL: nodejs#11153
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

misterdjules pushed a commit that referenced this pull request Feb 15, 2017

Julien Gilli
test: fix test.py command line options processing
#11086 had introduced a regression
that broke command line options processing for tools/test.py.

Basically, it made tools/test.py discard the command line argument that
would be passed after `--abort-on-timeout`. For instance, when running:

```
$ python tools/test.py --abort-on-timeout path/to/some-test
```

all tests would be run because the last command line argument
(`/path/to/some-test`) would be discarded.

This change fixes this regression.

Refs: #11086
PR-URL: #11153
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

misterdjules pushed a commit that referenced this pull request Feb 15, 2017

Julien Gilli
test: fix test.py command line options processing
#11086 had introduced a regression
that broke command line options processing for tools/test.py.

Basically, it made tools/test.py discard the command line argument that
would be passed after `--abort-on-timeout`. For instance, when running:

```
$ python tools/test.py --abort-on-timeout path/to/some-test
```

all tests would be run because the last command line argument
(`/path/to/some-test`) would be discarded.

This change fixes this regression.

Refs: #11086
PR-URL: #11153
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins added a commit that referenced this pull request Feb 21, 2017

test: fix test.py command line options processing
#11086 had introduced a regression
that broke command line options processing for tools/test.py.

Basically, it made tools/test.py discard the command line argument that
would be passed after `--abort-on-timeout`. For instance, when running:

```
$ python tools/test.py --abort-on-timeout path/to/some-test
```

all tests would be run because the last command line argument
(`/path/to/some-test`) would be discarded.

This change fixes this regression.

Refs: #11086
PR-URL: #11153
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins added a commit that referenced this pull request Feb 21, 2017

test: fix test.py command line options processing
#11086 had introduced a regression
that broke command line options processing for tools/test.py.

Basically, it made tools/test.py discard the command line argument that
would be passed after `--abort-on-timeout`. For instance, when running:

```
$ python tools/test.py --abort-on-timeout path/to/some-test
```

all tests would be run because the last command line argument
(`/path/to/some-test`) would be discarded.

This change fixes this regression.

Refs: #11086
PR-URL: #11153
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017

test: fix test.py command line options processing
nodejs#11086 had introduced a regression
that broke command line options processing for tools/test.py.

Basically, it made tools/test.py discard the command line argument that
would be passed after `--abort-on-timeout`. For instance, when running:

```
$ python tools/test.py --abort-on-timeout path/to/some-test
```

all tests would be run because the last command line argument
(`/path/to/some-test`) would be discarded.

This change fixes this regression.

Refs: nodejs#11086
PR-URL: nodejs#11153
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@misterdjules misterdjules deleted the misterdjules:fix-test-harness-cmdline-options-processing branch Jul 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment