New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add coverage for dgram send() errors #11248

Merged
merged 1 commit into from Feb 10, 2017

Conversation

Projects
None yet
5 participants
@cjihrig
Contributor

cjihrig commented Feb 8, 2017

This commit adds code coverage for emitted and callback errors for dgram's Socket#send() method.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@mscdex mscdex added the dgram label Feb 8, 2017

@jasnell

jasnell approved these changes Feb 9, 2017

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@mhdawson

LGTM

test: add coverage for dgram send() errors
This commit adds code coverage for emitted and callback errors
for dgram's Socket#send() method.

PR-URL: #11248
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@cjihrig cjihrig merged commit b32ae9e into nodejs:master Feb 10, 2017

@cjihrig cjihrig deleted the cjihrig:send-error branch Feb 10, 2017

italoacasas added a commit that referenced this pull request Feb 13, 2017

test: add coverage for dgram send() errors
This commit adds code coverage for emitted and callback errors
for dgram's Socket#send() method.

PR-URL: #11248
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

test: add coverage for dgram send() errors
This commit adds code coverage for emitted and callback errors
for dgram's Socket#send() method.

PR-URL: nodejs#11248
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017

test: add coverage for dgram send() errors
This commit adds code coverage for emitted and callback errors
for dgram's Socket#send() method.

PR-URL: nodejs#11248
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Mar 8, 2017

Member

Depends on common.mustNotCall, needs a backport PR to land in v6 or v4

Member

jasnell commented Mar 8, 2017

Depends on common.mustNotCall, needs a backport PR to land in v6 or v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment