Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors: port internal/net errors to internal/errors #11338

Closed
wants to merge 3 commits into from
Closed

errors: port internal/net errors to internal/errors #11338

wants to merge 3 commits into from

Conversation

bougarfaoui
Copy link

  • Assign codes to errors reported by internal/net.js

Ref: #11273

Semver-major because this updates specific error messages and converts errors over to use the new internal/errors.js mechanism.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

errors, net

@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. net Issues and PRs related to the net subsystem. labels Feb 13, 2017
@jasnell
Copy link
Member

jasnell commented Feb 13, 2017

May I ask why you closed this?

@bougarfaoui
Copy link
Author

bougarfaoui commented Feb 13, 2017 via email

@refack refack added this to Done in Error Codes Aug 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core. net Issues and PRs related to the net subsystem.
Projects
No open projects
Error Codes
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants