tls: fix leak on DoWrite() errors
#1154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is very unlikely to happen, but still the write request should be disposed in case of immediate failure.
| @@ -310,8 +310,10 @@ void TLSWrap::EncOut() { | |||
| write_req->Dispatched(); | |||
There was a problem hiding this comment.
Can I suggest that for consistency you write it as follows?
const int err = stream_->DoWrite(write_req, buf, count, nullptr);
write_req->Dispatched();
if (err < 0)
write_req->Dispose();There was a problem hiding this comment.
Gosh, I just realized that the condition was wrong here :)
|
LGTM with a suggestion. |
indutny
added a commit
that referenced
this pull request
Mar 14, 2015
It is very unlikely to happen, but still the write request should be disposed in case of immediate failure. PR-URL: #1154 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Landed in e90ed79, thank you! I have used |
This was referenced Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is very unlikely to happen, but still the write request should be
disposed in case of immediate failure.
cc @iojs/crypto @bnoordhuis