dns: minor refactor of dns module #11597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Feb 28, 2017
claudiorodriguez
approved these changes
Mar 2, 2017
targos
approved these changes
Mar 2, 2017
Move to the more efficient module.exports = {} pattern.
|
New CI after rebasing https://ci.nodejs.org/job/node-test-pull-request/6706/ |
jasnell
added a commit
that referenced
this pull request
Mar 4, 2017
Move to the more efficient module.exports = {} pattern.
PR-URL: #11597
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
|
Landed in 531de63 |
addaleax
pushed a commit
that referenced
this pull request
Mar 5, 2017
Move to the more efficient module.exports = {} pattern.
PR-URL: #11597
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
|
This doesn't land cleanly, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to the more efficient module.exports = {} pattern.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
dns