Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix a typo in api/process.md #11780

Closed
wants to merge 1 commit into from
Closed

doc: fix a typo in api/process.md #11780

wants to merge 1 commit into from

Conversation

sabakugaara
Copy link
Contributor

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

In process warning event sample code, it should be events.defaultMaxListeners

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Mar 10, 2017
@aqrln
Copy link
Contributor

aqrln commented Mar 10, 2017

commit message follows commit guidelines

It actually doesn't. The first line of the commit message should not exceed 50 characters. I'd suggest to reword it to something like doc: fix a typo in api/process.md and elaborate on that in the full message.

@sabakugaara sabakugaara changed the title doc: fix typo 'event' to 'events' in process module doc doc: fix a typo in api/process.md Mar 10, 2017
@sabakugaara
Copy link
Contributor Author

Thanks!

@aqrln
Copy link
Contributor

aqrln commented Mar 10, 2017 •
edited
Loading

@sabakugaara glad to help :) I'd also suggest you to make your full commit message more explicit because it isn't very clear, to be honest. How about this?

Fix a mistyped module name in example REPL sessions found in the
description of the 'warning' event: it should be `events` instead of
`event`.

Feel free to reword it as you like.

Trott
Trott approved these changes Mar 10, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sabakugaara
doc: fix a typo in api/process.md
05300e0 
Fix a mistyped module name in example REPL sessions found in the
description of the 'warning' event: it should be `events` instead of
`event`.
jasnell pushed a commit that referenced this pull request Mar 15, 2017
@sabakugaara @jasnell
doc: fix a typo in api/process.md
27f4c94 
Fix a mistyped module name in example REPL sessions found in the
description of the 'warning' event: it should be `events` instead of
`event`.

PR-URL: #11780
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member

jasnell commented Mar 15, 2017

Landed in 27f4c94

@jasnell jasnell closed this Mar 15, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 20, 2017
@sabakugaara @italoacasas
doc: fix a typo in api/process.md
e84e33c 
Fix a mistyped module name in example REPL sessions found in the
description of the 'warning' event: it should be `events` instead of
`event`.

PR-URL: nodejs#11780
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@italoacasas italoacasas mentioned this pull request Mar 20, 2017
Merged
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
@sabakugaara @jungx098
doc: fix a typo in api/process.md
a90f9b2 
Fix a mistyped module name in example REPL sessions found in the
description of the 'warning' event: it should be `events` instead of
`event`.

PR-URL: nodejs#11780
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
@sabakugaara @MylesBorins
doc: fix a typo in api/process.md
12772b0 
Fix a mistyped module name in example REPL sessions found in the
description of the 'warning' event: it should be `events` instead of
`event`.

PR-URL: #11780
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@sabakugaara @MylesBorins
doc: fix a typo in api/process.md
b8e3a5f 
Fix a mistyped module name in example REPL sessions found in the
description of the 'warning' event: it should be `events` instead of
`event`.

PR-URL: #11780
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@sabakugaara @andrew749
doc: fix a typo in api/process.md
11c20b2 
Fix a mistyped module name in example REPL sessions found in the
description of the 'warning' event: it should be `events` instead of
`event`.

PR-URL: nodejs/node#11780
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Mar 7, 2020
Open
Open
Open
Open
Open
@aliscco aliscco mentioned this pull request Dec 1, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Dec 1, 2023
Open
This was referenced Dec 1, 2023
Open
Open
This was referenced Dec 1, 2023
Open
Open
This was referenced Dec 1, 2023
Open
Open
@adamlaska adamlaska mentioned this pull request Dec 2, 2023
Open
@aliscco aliscco mentioned this pull request Dec 2, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Dec 2, 2023
Open
This was referenced Dec 2, 2023
Open
Open
Open
Open
@leonardoadame leonardoadame mentioned this pull request Dec 2, 2023
Open
This was referenced Dec 2, 2023
Open
Open
Open
This was referenced Dec 2, 2023
Open
Open
This was referenced Dec 2, 2023
Open
Open
This was referenced Dec 3, 2023
Open
Open
Open
@aliscco aliscco mentioned this pull request Dec 3, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Dec 3, 2023
Open
@aliscco aliscco mentioned this pull request Dec 3, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Dec 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@sabakugaara @aqrln @jasnell @Trott @lpinca @cjihrig @MylesBorins @nodejs-github-bot