Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a broken link #1204

Closed
wants to merge 1 commit into from
Closed

Fixed a broken link #1204

wants to merge 1 commit into from

Conversation

runeli
Copy link

@runeli runeli commented Mar 19, 2015

No description provided.

@Fishrock123
Copy link
Member

@runeli can you set your `git config --global user.name "Your Name"`` to your name, rather than your username? Thanks! :)

See also: https://github.com/iojs/io.js/blob/v1.x/CONTRIBUTING.md#step-3-commit

@Fishrock123 Fishrock123 added the doc Issues and PRs related to the documentations. label Mar 19, 2015
@runeli
Copy link
Author

runeli commented Mar 19, 2015

@Fishrock123 I just used the GitHub's web UI to make the change, had not noticed I have not set up that yet. Should be fine now. Thanks!

@Fishrock123
Copy link
Member

@runeli can you force-push a new change to this? Otherwise I'll just grab your full github name and amend it. :)

Fishrock123 pushed a commit that referenced this pull request Mar 19, 2015
PR-URL: #1204
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123
Copy link
Member

@runeli Thanks, Landed in 3bc445f -- I don't know what is wrong with github. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants