Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use option parser for expose_internals #12245

Merged
merged 2 commits into from Apr 13, 2017
Merged

src: use option parser for expose_internals #12245

merged 2 commits into from Apr 13, 2017

Commits on Apr 13, 2017

  1. src: supply missing comments for CLI options 

    A few of the CLI option values exposed as properties on the process
object were missing a comment, fix this.

PR-URL: #12245
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @sam-github
    sam-github committed Apr 13, 2017
    Copy the full SHA
    e505c07 View commit details
    Browse the repository at this point in the history

  2. src: use option parser for expose_internals 

    bootstrap_node.js was directly parsing process.execArgv to see if
internals should be exposed, even though the argv was already parsed by
node. This is unusual and unnecessary, change it to set the option value
from the parser onto the config binding.

PR-URL: #12245
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @sam-github
    sam-github committed Apr 13, 2017
    Copy the full SHA
    8086cb6 View commit details
    Browse the repository at this point in the history