Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix missing callback for dns.resolvePtr() #12256

Closed
wants to merge 1 commit into from
Closed

doc: fix missing callback for dns.resolvePtr() #12256

wants to merge 1 commit into from

Conversation

uppinder
Copy link
Contributor

@uppinder uppinder commented Apr 6, 2017

Fixes: #12161

Checklist
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations. labels Apr 6, 2017
vsemozhetbyt
vsemozhetbyt approved these changes Apr 6, 2017
View reviewed changes
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. LGTM with a nit: please, keep commit title length within 50 characters (currently 53).

@uppinder uppinder changed the title doc: fix missing callback argument for dns.resolvePtr doc: fix missing callback for dns.resolvePtr() Apr 6, 2017
@uppinder uppinder force-pushed the fix_missing_callback_argument branch from 27e4011 to 29084c7 Compare April 6, 2017 13:27
vsemozhetbyt pushed a commit that referenced this pull request Apr 8, 2017
@uppinder @vsemozhetbyt
doc: fix missing argument for dns.resolvePtr()
c095394 
PR-URL: #12256
Fixes: #12161
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@vsemozhetbyt
Copy link
Contributor

Landed in c095394

Thank you, @uppinder!

italoacasas pushed a commit to italoacasas/node that referenced this pull request Apr 10, 2017
@uppinder @italoacasas
doc: fix missing argument for dns.resolvePtr()
6826637 
PR-URL: nodejs#12256
Fixes: nodejs#12161
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@italoacasas italoacasas mentioned this pull request Apr 10, 2017
Merged
2 tasks
@MylesBorins
Copy link
Member

looks like this api is undocumented in v6.x. Does someone want to backport?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@lpinca lpinca lpinca approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation, dns.resolvePtr(hostname) missing callback argument
6 participants
@uppinder @vsemozhetbyt @MylesBorins @silverwind @lpinca @nodejs-github-bot