Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timers: assure setTimeout callback only runs once #1231

Closed
wants to merge 5 commits into from
Closed

timers: assure setTimeout callback only runs once #1231

wants to merge 5 commits into from

Commits on Mar 21, 2015

  1. timers: assure setTimeout callback only runs once 

    This fixes an edge case where running this.unref() during the callback caused the
callback to get executed multiple times.
    @silverwind
    silverwind committed Mar 21, 2015
    Configuration menu
    Copy the full SHA
    951168f View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2015

  1. Add _called to prototype

    @silverwind
    silverwind committed Mar 25, 2015
    Configuration menu
    Copy the full SHA
    bc94f6c View commit details
    Browse the repository at this point in the history

  2. Add test for unref during setInterval

    @silverwind
    silverwind committed Mar 25, 2015
    Configuration menu
    Copy the full SHA
    a58d149 View commit details
    Browse the repository at this point in the history

  3. Let timer unenroll and prevent setInterval issues

    @silverwind
    silverwind committed Mar 25, 2015
    Configuration menu
    Copy the full SHA
    c99318c View commit details
    Browse the repository at this point in the history

  4. Add note to setInterval test

    @silverwind
    silverwind committed Mar 25, 2015
    Configuration menu
    Copy the full SHA
    1a824b1 View commit details
    Browse the repository at this point in the history