-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(v7.x-backport) build: enable cctest to use generated objects #12321
Conversation
Current CI failures are nodejs/build#681, nodejs/build#682 and #12104 (comment). |
New CI: https://ci.nodejs.org/job/node-test-pull-request/7340/ All seems to be good except for a known issue for |
This commit tries to make it simpler to add unit tests (cctest) for code that needs to test node core funtionality but that might not be appropriate as an addon or a JavaScript test. An example of this could be adding functionality targeted for situations when Node itself is embedded. Currently it was not as easy, or efficient, as one would have hoped to add such tests. The object output directories vary for different operating systems which we need to link to so that we don't have an additional compilation step. PR-URL: nodejs#11956 Ref: nodejs#9163 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#11956 Ref: nodejs#9163 Reviewed-By: James M Snell <jasnell@gmail.com>
5535847
to
2894692
Compare
Force-pushed with full original commit messages (no metadata removed). Ref: nodejs/Release#191 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI is happy
Landed in 75f0855. Thanks! |
Backport #11956 to v7.x. PRs #12042 and #12238 (both labeled as "backport-to-v7.x") depend on it.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
build, doc