src: expose V8's IsNativeError() in util bindings #12546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
addaleax
approved these changes
Apr 21, 2017
thefourtheye
approved these changes
Apr 21, 2017
jasnell
approved these changes
Apr 25, 2017
TimothyGu
reviewed
Apr 25, 2017
test/parallel/test-util.js
Outdated
| assert.strictEqual(binding.isNativeError(new TypeError()), true); | ||
| assert.strictEqual(binding.isNativeError(new SyntaxError()), true); | ||
| /* eslint-disable new-parens */ | ||
| assert.strictEqual(binding.isNativeError(new (context('Error'))), true); |
There was a problem hiding this comment.
new (context('Error'))()
I think that should fulfill the "new-parens" ESLint rule as well.
Refs: nodejs#12400 PR-URL: nodejs#12546 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
cjihrig
force-pushed
the
is-native-error
branch
from
cfd869e
to
e522bcd
Compare
|
Landed with @TimothyGu's suggestion. |
Merged
|
I get this error when backporting this to v6.x, which I assume means that this shouldn't land. LMK if that's not the case. |
|
Fwiw the v8 patch that would fix that failure is v8/v8@a2dad04, I think. |
|
If this is something that's worth landing on Node 6, then a backport PR with e522bcd and v8/v8@a2dad04 would be welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes
IsNativeError()throughprocess.binding('util'). The tests are copied fromutil.isError(). The results are the same with the exception of the last one (object inheriting fromError).R= @addaleax because of #12400 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src